Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RN SDK v6 migration guide #11346

Merged
merged 9 commits into from
Oct 15, 2024
Merged

feat: Add RN SDK v6 migration guide #11346

merged 9 commits into from
Oct 15, 2024

Conversation

krystofwoldrich
Copy link
Member

DESCRIBE YOUR PR

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: The week of 30 September the RN v6 stable version will be published
  • None: Not urgent, can wait up to 1 week+

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 3:15pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 3:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 3:15pm

@krystofwoldrich krystofwoldrich mentioned this pull request Sep 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 14.1MB (99.62%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
sentry-docs-server* 7.46MB 7.46MB (100%) ⬆️⚠️
sentry-docs-edge-server* 254.44kB 254.44kB (100%) ⬆️⚠️
sentry-docs-client* 6.38MB 6.38MB (100%) ⬆️⚠️
sentry-docs-server-cjs 7.46MB 387 bytes (0.01%) ⬆️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 6 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

lizokm
lizokm approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions :)

docs/platforms/react-native/migration/before-v5.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/before-v5.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/before-v5.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/before-v5.mdx Show resolved Hide resolved
docs/platforms/react-native/migration/before-v5.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/v5-to-v6.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/v5-to-v6.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/v5-to-v6.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/v5-to-v6.mdx Outdated Show resolved Hide resolved
docs/platforms/react-native/migration/v5-to-v6.mdx Outdated Show resolved Hide resolved
@getsantry

This comment was marked as outdated.

Sign in to view
@getsantry getsantry bot added the Stale label Oct 8, 2024
@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented Oct 11, 2024 •
edited
Loading

The preview URL is not loading for me :\
https://sentry-docs-git-kw-react-native-v6-migration-guide.sentry.dev/

EDIT: I am able to see it with VPN

@lucas-zimerman
Copy link
Collaborator

image
Not related to the PR but snippets with diffs seems to cut the start of the diff ( you can still copy the selected code without issue)

https://sentry-docs-git-kw-react-native-v6-migration-guide.sentry.dev/platforms/react-native/migration/sentry-expo/#fix-imports

lucas-zimerman
lucas-zimerman approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small notes but other than that looks good to me, Let's merge it after the changes!

antonis
antonis approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Added minor NIT picks/suggestions.

@krystofwoldrich
Copy link
Member Author

@lucas-zimerman Thank you for checking the diffs.

It's not related to this PR, but seems like javascript {tabTitle:JavaScript} diff working. But diff {tabTitle:JavaScript} causes the bad styling.

@krystofwoldrich krystofwoldrich merged commit 121342d into master Oct 15, 2024
11 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/react-native-v6-migration-guide branch October 15, 2024 15:17
@krystofwoldrich krystofwoldrich mentioned this pull request Oct 15, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lizokm lizokm lizokm approved these changes

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@antonis antonis antonis approved these changes

@kahest kahest Awaiting requested review from kahest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krystofwoldrich @lucas-zimerman @antonis @lizokm