Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: document all profiler runtime flags #11382

Merged
merged 8 commits into from
Sep 19, 2024
Merged

ref: document all profiler runtime flags #11382

merged 8 commits into from
Sep 19, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Sep 17, 2024

DESCRIBE YOUR PR

Documents profiler runtime flags, fixes #11128

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:32pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:32pm

@JonasBa JonasBa mentioned this pull request Sep 17, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 153 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 162 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

andreiborza
andreiborza reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Are these docs ever different between platforms? Wonder if we could just lift them up to common and avoid the duplication.

docs/platforms/javascript/guides/aws-lambda/profiling/index.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/aws-lambda/profiling/index.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/aws-lambda/profiling/index.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/aws-lambda/profiling/index.mdx Outdated Show resolved Hide resolved
lizokm
lizokm approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, but otherwise looks great from my end.

includes/profiling-node-runtime-flags.mdx Outdated Show resolved Hide resolved
includes/profiling-node-runtime-flags.mdx Outdated Show resolved Hide resolved
@JonasBa JonasBa enabled auto-merge (squash) September 19, 2024 20:13
@JonasBa JonasBa merged commit c7438a2 into master Sep 19, 2024
10 checks passed
@JonasBa JonasBa deleted the jb/profiling/node-env-option branch September 19, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreiborza andreiborza andreiborza left review comments

@lizokm lizokm lizokm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing documentation about the SENTRY_PROFILER_BINARY_DIR and SENTRY_PROFILER_BINARY_PATH env variable
3 participants
@JonasBa @lizokm @andreiborza