Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(custom-views): Add custom views documentation #11390

Merged
merged 10 commits into from
Sep 25, 2024

Conversation

MichaelSun48
Copy link
Member

@MichaelSun48 MichaelSun48 commented Sep 18, 2024

This PR adds documentation for the custom issue views feature. Also updates some saved searches documentation to signal that it is deprecated and slated for removal.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Sep 25, 2024 7:06pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 7:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 7:06pm

Copy link

codecov bot commented Sep 18, 2024

Bundle Report

Changes will increase total bundle size by 650 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 659 bytes (0.01%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first pass. You're a good writer and should not discount your skills! Let me know when you'd like me to take another look :)

docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/custom-views/index.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few more minor tweaks.

docs/concepts/search/saved-searches.mdx Outdated Show resolved Hide resolved
docs/product/issues/issue-priority/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/issue-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/issue-views/index.mdx Outdated Show resolved Hide resolved
docs/product/issues/issue-views/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: Liza Mock <[email protected]>
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only!

docs/product/issues/issue-priority/index.mdx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The call out in the screenshot says Early Adopter only which will become outdated when this releases. Might have to do some manual DOM editing to get around it, but will prevent the screenshot from becoming dated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on this!

@MichaelSun48 MichaelSun48 merged commit 4eee643 into master Sep 25, 2024
9 of 10 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/addCustomViewsDocs branch September 25, 2024 19:29
MichaelSun48 added a commit to getsentry/sentry that referenced this pull request Sep 25, 2024
…sable, feedback -> read docs (#77878)

Makes a couple changes to the add view page for EA readiness: 

1. Updates the banner copy to call out: views are user scoped, views are
reorderable, and that custom searches are persisted temporarily (only
appears if you actually have any custom searches)
2. Adds a dismiss button to the banner 
3. Switches the "Give Feedback" button for a "Read Docs" button 
4. Adds a "Learn More" link to docs within the saved searches tooltip 


**IMPORTANT**: Issue views docs have not been merged in yet, so the docs
links are **broken**. I will not merge this until the docs links
resolve. [Docs PR](getsentry/sentry-docs#11390)
if you're curious about it.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants