-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(custom-views): Add custom views documentation #11390
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 650 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first pass. You're a good writer and should not discount your skills! Let me know when you'd like me to take another look :)
Co-authored-by: Liza Mock <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few more minor tweaks.
Co-authored-by: Liza Mock <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The call out in the screenshot says Early Adopter only
which will become outdated when this releases. Might have to do some manual DOM editing to get around it, but will prevent the screenshot from becoming dated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work on this!
…sable, feedback -> read docs (#77878) Makes a couple changes to the add view page for EA readiness: 1. Updates the banner copy to call out: views are user scoped, views are reorderable, and that custom searches are persisted temporarily (only appears if you actually have any custom searches) 2. Adds a dismiss button to the banner 3. Switches the "Give Feedback" button for a "Read Docs" button 4. Adds a "Learn More" link to docs within the saved searches tooltip **IMPORTANT**: Issue views docs have not been merged in yet, so the docs links are **broken**. I will not merge this until the docs links resolve. [Docs PR](getsentry/sentry-docs#11390) if you're curious about it.
This PR adds documentation for the
customissue views feature. Also updates some saved searches documentation to signal that it is deprecated and slated for removal.