Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update org members can edit project ownership rules #11400

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

jangjodi
Copy link
Member

Add that Org Members can edit project ownership rules

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Sep 24, 2024 8:16pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 8:16pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 8:16pm

@jangjodi jangjodi requested a review from a team September 19, 2024 16:53
Copy link

codecov bot commented Sep 19, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

@@ -35,7 +35,7 @@ Organization-level roles enable broad access to the entire organization, as desc
| Can view and act on issues (such as assigning and resolving) | | ✓ | ✓ | ✓ | ✓ |
| Can join and leave existing teams | | ✓ | ✓ | ✓ | ✓ |
| Can add repositories (through GitHub integrations) | | ✓ | ✓ | ✓ | ✓ |
| Can create and remove teams from the organization | | | ✓ | ✓ | ✓ |
| Can create and remove teams from the organization | | ✓\*\* | ✓ | ✓ | ✓ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this comes before "Can create and remove projects for the organization", should we swap the footnotes? Here will be ✓\* and ✓\*\* is below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I've fixed the ordering

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. I have one small clarifying question for you :)

docs/organization/membership/index.mdx Outdated Show resolved Hide resolved
docs/organization/membership/index.mdx Outdated Show resolved Hide resolved
jangjodi and others added 3 commits September 24, 2024 09:54
docs/organization/membership/index.mdx Outdated Show resolved Hide resolved
@jangjodi jangjodi merged commit 82692db into master Sep 24, 2024
9 of 10 checks passed
@jangjodi jangjodi deleted the jodi/project-ownership-rules branch September 24, 2024 21:22
gaprl pushed a commit that referenced this pull request Sep 24, 2024
Add that org members can edit project ownership rules

Co-authored-by: Liza Mock <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants