Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter: improve session and screenshots docs #11708

Merged
merged 14 commits into from
Nov 11, 2024
Merged

Conversation

buenaflor
Copy link
Contributor

DESCRIBE YOUR PR

Update snippets and wording

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 4:03pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 4:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 4:03pm

Copy link

codecov bot commented Nov 1, 2024

Bundle Report

Changes will decrease total bundle size by 18 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.31MB 9 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 333.11kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 6 bytes (-0.0%) ⬇️

Copy link
Collaborator

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple suggestions, looks good! Thanks for updating!

@buenaflor buenaflor marked this pull request as ready for review November 11, 2024 15:47
@buenaflor buenaflor enabled auto-merge (squash) November 11, 2024 15:47
@buenaflor buenaflor merged commit 8ebae05 into master Nov 11, 2024
11 checks passed
@buenaflor buenaflor deleted the flutter/fix-sessions branch November 11, 2024 16:03
vaind pushed a commit that referenced this pull request Nov 11, 2024
* improve docs

* update

* update

* update snippet

* update doc

* update screenshots

* Update docs/platforms/flutter/configuration/options.mdx

Co-authored-by: Alex Krawiec <[email protected]>

* Update docs/platforms/flutter/configuration/releases.mdx

Co-authored-by: Alex Krawiec <[email protected]>

* Update platform-includes/configuration/auto-session-tracking/flutter.mdx

Co-authored-by: Alex Krawiec <[email protected]>

* Update platform-includes/enriching-events/attach-screenshots/flutter.mdx

Co-authored-by: Alex Krawiec <[email protected]>

* Update platform-includes/configuration/auto-session-tracking/flutter.mdx

Co-authored-by: Alex Krawiec <[email protected]>

* update code snippets

* update code snippets

* update code snippets

---------

Co-authored-by: Alex Krawiec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants