updating multiple JS frameworks to and more detailed source map info #14454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 960 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
sfanahata
changed the title
s1gr1d
reviewed
Jul 28, 2025
Comment on lines
+69
to
+71
| assets: ["./output/**/*"], | ||
| ignore: ["**/node_modules/**"], | ||
| filesToDeleteAfterUpload: ["./output/**/*.map"], |
There was a problem hiding this comment.
The SDK automatically sets those values, so people usually don't have to add something here.
But the default values would be:
filesToDeleteAfterUpload: [
/* client */ '.*/**/public/**/*.map', // deleting this is more important as it's client-side
/* server */ '.*/**/server/**/*.map', '.*/**/output/**/*.map', '.*/**/function/**/*.map'
],
assets: undefined // it's undefined as we can't know exactly where the build is located.
// But it could be:
// assets: ['./.output/server/**/*']
Lms24
reviewed
Jul 28, 2025
Comment on lines
+70
to
+74
| sourcemaps: { | ||
| assets: ["./build/*/**/*"], | ||
| ignore: ["**/build/client/**/*"], | ||
| filesToDeleteAfterUpload: ["./build/**/*.map"], | ||
| }, |
There was a problem hiding this comment.
same concern as @s1gr1d had above: These options aren't required. Either we clearly state that users can set them if the default behaviour doesn't work for them, or we just omit them. Happy to leave the decision up to you :)
Suggested change
| sourcemaps: { | |
| assets: ["./build/*/**/*"], | |
| ignore: ["**/build/client/**/*"], | |
| filesToDeleteAfterUpload: ["./build/**/*.map"], | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: