Skip to content

replays: Add delete docs #14557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

cmanallen
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): Immediate.
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 8:16pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2025 8:16pm

Copy link

codecov bot commented Aug 5, 2025

Bundle Report

Changes will increase total bundle size by 6.67kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.36MB 6.67kB (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/lMluS5GpjcWjQXmwxHImu/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/lMluS5GpjcWjQXmwxHImu/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/W84V3ihBRYEI689c0Du_w/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/W84V3ihBRYEI689c0Du_w/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.77MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 2.23kB 740.9kB 0.3%
../app/platform-redirect/page.js.nft.json 2.23kB 740.82kB 0.3%
../app/sitemap.xml/route.js.nft.json 2.23kB 738.29kB 0.3%


## Deleting Replays in Bulk

Replays can be bulk deleted from a selection set or from a query. To bulk delete replays click the empty checkbox on the left-hand side of the session replay row.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested clarification: "To bulk delete replays [select a single project from the dropdown and] click the empty checkbox..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a reference to this in session-replay/web/index.mdx

Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist and delete button images feel kinda big to me, the #deleting-replays-in-bulk section

@jas-kas
Copy link
Member

jas-kas commented Aug 6, 2025

@cmanallen @ryan953 Reviewed the new "Delete Session Replays" page.

I found it's too much of a step-by-step instruction of how to execute on the delete workflow when the delete process is pretty intuitive/straight-forward IMO. As soon as you highlight where the Delete button is on the Replay Details page, and the delete checkboxes on the Replay (Index) page, I think that's enough instruction. It's probably worth adding that a note about the View Progress Settings view since that is a new pattern we're introducing.

It might be good to include what kind of 'delete' this is -- what happens to the data after someone hits 'delete' in the UI?

I also don't think this should be a top-level navigation item under "Session Replay" since it's not a core aspect of the product, I'd add it as a heading called "Deleting Replays" under this page: https://docs.sentry.io/product/explore/session-replay/web/replay-page-and-filters/. I know this page is under Session Replay for Web when it could be really generalized for both Web & Mobile, but I think that's OK for now.

@bruno-garcia
Copy link
Member

image

Can we set some max size for the images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants