-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
replays: Add delete docs #14557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
replays: Add delete docs #14557
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 6.67kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
|
||
## Deleting Replays in Bulk | ||
|
||
Replays can be bulk deleted from a selection set or from a query. To bulk delete replays click the empty checkbox on the left-hand side of the session replay row. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested clarification: "To bulk delete replays [select a single project from the dropdown and] click the empty checkbox..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a reference to this in session-replay/web/index.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist and delete button images feel kinda big to me, the #deleting-replays-in-bulk section
@cmanallen @ryan953 Reviewed the new "Delete Session Replays" page. I found it's too much of a step-by-step instruction of how to execute on the delete workflow when the delete process is pretty intuitive/straight-forward IMO. As soon as you highlight where the It might be good to include what kind of 'delete' this is -- what happens to the data after someone hits 'delete' in the UI? I also don't think this should be a top-level navigation item under "Session Replay" since it's not a core aspect of the product, I'd add it as a heading called "Deleting Replays" under this page: https://docs.sentry.io/product/explore/session-replay/web/replay-page-and-filters/. I know this page is under Session Replay for Web when it could be really generalized for both Web & Mobile, but I think that's OK for now. |
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES