Skip to content

Update sdkOption to avoid rendering divs inside of tables #14562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

coolguyzone
Copy link
Contributor

@coolguyzone coolguyzone commented Aug 5, 2025

DESCRIBE YOUR PR

SDK option tables were missing their bottom borders because the PlatformSection inside of them was rendering a div, semantically we shouldn't have divs inside our tables. I added a function and some logic to manually check the platform instead.

See a platform options page such as: https://sentry-docs-git-table-borders.sentry.dev/platforms/python/configuration/options/ and compare to what we have in prod: https://docs.sentry.io/platforms/python/configuration/options/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 10:29pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 10:29pm

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Aug 5, 2025

Bundle Report

Changes will increase total bundle size by 2.01kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.36MB 2.01kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/rZ5c629iL_vHyI-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/rZ5c629iL_vHyI-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/W84V3ihBRYEI689c0Du_w/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/W84V3ihBRYEI689c0Du_w/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.77MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 715 bytes 739.39kB 0.1%
../app/platform-redirect/page.js.nft.json 715 bytes 739.3kB 0.1%
../app/sitemap.xml/route.js.nft.json 715 bytes 736.78kB 0.1%
../app/[[...path]]/page.js -122 bytes 567.32kB -0.02%

Files in ../app/[[...path]]/page.js:

  • ./src/components/sdkOption.tsx → Total Size: 4.78kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -122 bytes 3.13MB -0.0%

@coolguyzone
Copy link
Contributor Author

Screenshot 2025-08-05 at 1 23 04 PM

Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants