-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding defaults for Godot options #15216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type changes aren’t exact. Godot uses short names like bool
and int
. Here’s a link to Godot’s type specifications for reference: https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_basics.html#built-in-types
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
@limbonaut thanks for all the updates! Feel free to just call out the type format discrepancy once next time and I'll change them on my side. =] I committed all the changes. Feel free to give another look. |
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
Co-authored-by: Serhii Snitsaruk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
DESCRIBE YOUR PR
Adding missing options since changing over SDKoption for all option formatting.
Preview: https://sentry-docs-git-godot-options-updates.sentry.dev/platforms/godot/configuration/options/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: