Skip to content

Conversation

sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Oct 14, 2025

DESCRIBE YOUR PR

Adding missing options since changing over SDKoption for all option formatting.

Preview: https://sentry-docs-git-godot-options-updates.sentry.dev/platforms/godot/configuration/options/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Canceled Canceled Oct 22, 2025 5:46pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 22, 2025 5:46pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 14, 2025 21:33
@codecov
Copy link

codecov bot commented Oct 14, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/_aC13GLnJO9bmJCayxqu0/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/_aC13GLnJO9bmJCayxqu0/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/yut_gdq4lY52bSTpqiwzW/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/yut_gdq4lY52bSTpqiwzW/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

Copy link
Collaborator

@limbonaut limbonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type changes aren’t exact. Godot uses short names like bool and int. Here’s a link to Godot’s type specifications for reference: https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_basics.html#built-in-types

sfanahata and others added 14 commits October 22, 2025 09:39
@sfanahata
Copy link
Contributor Author

@limbonaut thanks for all the updates! Feel free to just call out the type format discrepancy once next time and I'll change them on my side. =]

I committed all the changes. Feel free to give another look.

cursor[bot]

This comment was marked as outdated.

@sfanahata sfanahata requested a review from limbonaut October 22, 2025 16:46
Copy link
Collaborator

@limbonaut limbonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants