Skip to content

Updated dotnet options to include all defaults #15218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2025
Merged

Updated dotnet options to include all defaults #15218

merged 6 commits into from
Oct 23, 2025
+10 −20

Conversation

@sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Oct 14, 2025 •
edited
Loading

DESCRIBE YOUR PR

Updated options with defaults based on move to SDKoption formatting.

Preview: https://sentry-docs-git-dotnet-options-updates.sentry.dev/platforms/dotnet/configuration/options/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 23, 2025 3:29pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 23, 2025 3:29pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 14, 2025 22:09
@sfanahata
Copy link
Contributor Author

sfanahata commented Oct 14, 2025 •
edited
Loading

@bitsandfoxes - I made some guesses and approximations to defaults based on other SDKs. Please correct where it's wrong. Thanks!

❓AttachStacktrace = true - Java and Android use true
❓ AttachScreenshot = false - Flutter/Android use false
❓ ScreenshotQuality = "high" - Flutter uses high
❓ SendClientReports = true - Standard across other SDKs
❓ CaptureFailedRequests = false - Android uses false
❓ MaxRequestBodySize = "none" - Java uses never
❓ TracesSampleRate = 0.0 - Standard across other SDKs

@sfanahata sfanahata mentioned this pull request Oct 14, 2025
Closed
@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/n9Q59hH987QcwL37UeE7o/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/n9Q59hH987QcwL37UeE7o/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Ob9t02TpyAr5ZEVjkTMh_/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/Ob9t02TpyAr5ZEVjkTMh_/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

bitsandfoxes
bitsandfoxes reviewed Oct 22, 2025
View reviewed changes
docs/platforms/dotnet/common/configuration/options.mdx Outdated
<PlatformSection supported={["dotnet.xamarin"]}>

<SdkOption name="ScreenshotQuality" type="enum">
<SdkOption name="ScreenshotQuality" type="enum" defaultValue="high">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have slipped through, I can't find ScreenshotQuality in neither the .NET SDK nor its Xamarin flavor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScreenshotQuality is weird. It seems like there are mentions of it in this sentry-xamarin pull request: getsentry/sentry-xamarin#76 (comment)

But Don't see it mentioned anywhere in the code itself...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Sounds like maybe we remove it then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes, @bitsandfoxes Should we remove this?

@codeowner-assignment codeowner-assignment bot requested a review from a team October 22, 2025 16:48
@codeowner-assignment codeowner-assignment bot requested a review from a team October 23, 2025 08:21
bitsandfoxes
bitsandfoxes approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeowner-assignment codeowner-assignment bot requested a review from a team October 23, 2025 08:22
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Case Mismatch in StackTraceMode Default Value

The StackTraceMode option's defaultValue is "enhanced" (lowercase), but the documentation and enum values consistently use "Enhanced" (capitalized). This casing difference may prevent the SDK from correctly applying the default value.

Fix in Cursor Fix in Web

alexsohn1126
alexsohn1126 approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@alexsohn1126 alexsohn1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfanahata sfanahata merged commit 96345e7 into master Oct 23, 2025
13 checks passed
@sfanahata sfanahata deleted the dotnet-options-updates branch October 23, 2025 17:11
codyde added a commit that referenced this pull request Oct 27, 2025
@codyde
Merge remote-tracking branch 'origin/master' into docs/js-span-metric…
a8f8bae 
…s-examples

* origin/master: (478 commits)
  docs(godot): Structured logging (#15287)
  fix(batch-processor): Don't enforce starting timer (#15309)
  feat(node): Add new options to nativeNodeFetchIntegration (#15282)
  Updated dotnet options to include all defaults (#15218)
  ref: add docs that logs channel is optional (#15172)
  docs(svelteKit): Update build-time options for source maps (#15283)
  fix(python): Fix paragraph order in Strawberry docs (#15301)
  Added docs explaining how to disable Sentry Native in the .NET SDK (#15293)
  Updated Unity options with missing defaults (#15219)
  docs(otlp): Update docs for client SDK w3c traceparent support (#15294)
  Adding defaults for Godot options (#15216)
  feat(crons): Document broken monitors feature (#15280)
  fix: Remove OTLP logs from EA list (#15288)
  Bump API schema to 06047b60 (#15276)
  ref(nextjs): Move manual instrumentation examples for ai into Edge section (#15284)
  docs(otlp): change status to open beta (#15285)
  Hono runtime and middleware doc updates (#14853)
  feat(logs): Clarify API for Hub/Scope and Client (#15281)
  docs(astro/nuxt): Remove `sourceMapsUploadOptions` option nesting (#14905)
  docs(profiling): Add docs for Profiling API (#15258)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

@alexsohn1126 alexsohn1126 alexsohn1126 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfanahata @bitsandfoxes @alexsohn1126