-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(svelteKit): Update build-time options for source maps #15283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
docs/platforms/javascript/guides/sveltekit/configuration/build/index.mdx
Outdated
Show resolved
Hide resolved
| <SdkOption name="sentryUrl" type="string" envVar="SENTRY_URL" defaultValue="https://sentry.io/"> | ||
|
|
||
| The base URL of your Sentry instance. Only relevant if you're using a self-hosted or Sentry instance other than sentry.io. | ||
| The base URL of your Sentry instance. Only relevant if you're using a self-hosted or Sentry instance other than sentry.io. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a case where someone is using a different Sentry instance that isn't self-hosted? Or can this be simplified to "Only relevant if you're using a self-hosted Sentry instance."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but I would still include the first sentence as it explains what it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎃
Co-authored-by: Alex Krawiec <[email protected]>
DESCRIBE YOUR PR
Updating docs based on this PR: getsentry/sentry-javascript#17413
Related to this project: getsentry/sentry-javascript#14212
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: