Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 22, 2025

DESCRIBE YOUR PR

Updating docs based on this PR: getsentry/sentry-javascript#17413

Related to this project: getsentry/sentry-javascript#14212

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@s1gr1d s1gr1d requested a review from inventarSarah October 22, 2025 13:37
@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 23, 2025 3:02pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 23, 2025 3:02pm

@s1gr1d s1gr1d requested review from Lms24 and Copilot and removed request for Copilot October 22, 2025 13:37
@codecov
Copy link

codecov bot commented Oct 22, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/YXwas6-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/YXwas6-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/GJplHyzjCtci1Tatjb9kQ/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/GJplHyzjCtci1Tatjb9kQ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

<SdkOption name="sentryUrl" type="string" envVar="SENTRY_URL" defaultValue="https://sentry.io/">

The base URL of your Sentry instance. Only relevant if you're using a self-hosted or Sentry instance other than sentry.io.
The base URL of your Sentry instance. Only relevant if you're using a self-hosted or Sentry instance other than sentry.io.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a case where someone is using a different Sentry instance that isn't self-hosted? Or can this be simplified to "Only relevant if you're using a self-hosted Sentry instance."?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I would still include the first sentence as it explains what it is.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@inventarSarah inventarSarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎃

@s1gr1d s1gr1d enabled auto-merge (squash) October 23, 2025 14:37
@s1gr1d s1gr1d merged commit 935b95a into master Oct 23, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/sveltekit-buildOptions-sourcemap branch October 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants