-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to manually use withSentry
from Next.js docs
#5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lforst
changed the title
Remove references to manually use withSentry from Next.js docs
Remove references to manually use Sep 22, 2022
withSentry
from Next.js docs
43 tasks
lforst
force-pushed
the
lforst-remove-with-sentry-references
branch
2 times, most recently
from
September 22, 2022 11:52
2ed28e2
to
86ea721
Compare
imatwawana
reviewed
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some styling edits
src/platform-includes/performance/connect-services/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/what-instrumentation-provides/javascript.nextjs.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/what-instrumentation-provides/javascript.nextjs.mdx
Outdated
Show resolved
Hide resolved
Sorry for tagging everybody 😬 Git be hard sometimes |
lforst
force-pushed
the
lforst-remove-with-sentry-references
branch
from
October 10, 2022 10:58
b712f5c
to
d5f58ef
Compare
AbhiPrasad
approved these changes
Oct 10, 2022
Co-authored-by: Abhijeet Prasad <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: getsentry/sentry-javascript#5505
Removes all references and instructions to use
withSentry
from the docs, under the assumption that users will use our new auto-wrapping functionality of Next.js data fetching methods and API routes instead.