ref: Clarify JS tracingOrigins Default Values
#5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
changed the title
tracingOrigins Default Values
imatwawana
approved these changes
Oct 5, 2022
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <[email protected]>
Lms24
force-pushed
the
lms-clarify-tracingOrigins-default-values
branch
from
cd19766
to
fe73f04
Compare
lforst
pushed a commit
that referenced
this pull request
Oct 10, 2022
Clarify the meaning of the JS SDK's default values for the `tracingOrigins` option of the `BrowserTracing` integration. As pointed out in getsentry/sentry-javascript#5868 ([comment](getsentry/sentry-javascript#5868 (comment))), it is not obvious on first glance, to which requests tracing headers are attached if the default values are used. This PR therefore adds an explanation and slightly changes the ordering of the `tracingOrigins` description. Co-authored-by: Isabel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the meaning of the JS SDK's default values for the
tracingOriginsoption of theBrowserTracingintegration. As pointed out in getsentry/sentry-javascript#5868 (comment), it is not obvious on first glance, to which requests tracing headers are attached if the default values are used. This PR therefore adds an explanation and slightly changes the ordering of thetracingOriginsdescription.