Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update JS docs to use top level tracePropagationTargets #7267

Merged
merged 2 commits into from
Jul 10, 2023
Merged

feat: Update JS docs to use top level tracePropagationTargets #7267

merged 2 commits into from
Jul 10, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jun 26, 2023 •
edited
Loading

ref getsentry/sentry-javascript#8352

Can only be merged after #7176 is merged in and getsentry/sentry-javascript#8399 is released.

@AbhiPrasad AbhiPrasad self-assigned this Jun 26, 2023
@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 7:03pm

@AbhiPrasad AbhiPrasad mentioned this pull request Jun 26, 2023
Closed
@AbhiPrasad AbhiPrasad marked this pull request as ready for review June 28, 2023 18:37
@AbhiPrasad AbhiPrasad requested review from shanamatthews, a team, mydea and stephanie-anderson and removed request for a team June 28, 2023 18:38
shanamatthews
shanamatthews reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change also have been made in src/platform-includes/performance/configure-sample-rate/javascript.electron.mdx and src/platform-includes/performance/configure-sample-rate/javascript.vue.mdx ?

@AbhiPrasad
Copy link
Member Author

src/platform-includes/performance/configure-sample-rate/javascript.electron.mdx can only be updated when electron makes a release as has a separate release lifecycle than the rest of the js sdks - but good call on src/platform-includes/performance/configure-sample-rate/javascript.vue.mdx, will update.

@shanamatthews
Copy link
Contributor

Perf - nothing else from the docs side on this in that case 😄

@AbhiPrasad AbhiPrasad force-pushed the abhi-trace-propagation-target branch from 034857b to 858e8a9 Compare July 10, 2023 18:48
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 10, 2023 18:49
@AbhiPrasad
Copy link
Member Author

Release has been out for 2 weeks, so merging in now https://github.com/getsentry/sentry-javascript/releases/tag/7.57.0

@AbhiPrasad AbhiPrasad merged commit dd1f474 into master Jul 10, 2023
6 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-trace-propagation-target branch July 10, 2023 19:02
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 17, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shanamatthews shanamatthews shanamatthews approved these changes

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @shanamatthews @Lms24