feat(js): Add js tracing without performance docs #7421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea and
ale-cota
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lizokm
approved these changes
Jul 13, 2023
src/platform-includes/distributed-tracing/how-to-use/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/distributed-tracing/how-to-use/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/distributed-tracing/how-to-use/javascript.nextjs.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/distributed-tracing/how-to-use/javascript.nextjs.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/distributed-tracing/how-to-use/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/distributed-tracing/how-to-use/javascript.sveltekit.mdx
Outdated
Show resolved
Hide resolved
| }); | ||
| ``` | ||
|
|
||
| If you're using express or an express-compatible framework, you also need to use the Sentry middleware: |
There was a problem hiding this comment.
Suggested change
| If you're using express or an express-compatible framework, you also need to use the Sentry middleware: | |
| If you're using express or an express-compatible framework, you'll also need to use Sentry middleware: |
Co-authored-by: Liza Mock <[email protected]>
shanamatthews
pushed a commit
that referenced
this pull request
Jul 31, 2023
Co-authored-by: Liza Mock <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
See: getsentry/sentry-javascript#8352
Documents tracing without performance in the JS SDKs.