Update GraphQL docs for Java SDK #7647

adinauer · 2023-08-16T07:30:39Z

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

Checked Vercel preview for correctness, including links
PR was reviewed and approved by any necessary SMEs
PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Documents changes done in getsentry/sentry-java#2856

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Sentry Docs contributor guide

vercel · 2023-08-16T07:30:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 18, 2023 8:38am

src/platforms/java/common/configuration/integrations/graphql.mdx

lbloder

LGTM 👍

lizokm

Looks great, just made some language tweaks. Hopefully they aren't changing the meaning.

src/platforms/java/common/configuration/integrations/graphql.mdx

lizokm · 2023-08-17T19:59:20Z

src/platforms/java/common/configuration/integrations/graphql.mdx

+Create a new instance of `SentryGenericDataFetcherExceptionHandler`, pass the delegate that handles the exception, and configure `defaultDataFetcherExceptionHandler` when building a `GraphQL` instance.
+Create a new instance of `SentryInstrumentation` and configure `instrumentation` when building a `GraphQL` instance.
+You may want to filter some of the errors by using `beforeSend` or an `EventProcessor` (see <PlatformLink to="/configuration/filtering/">Filters</PlatformLink>).


Suggested change

Create a new instance of `SentryGenericDataFetcherExceptionHandler`, pass the delegate that handles the exception, and configure `defaultDataFetcherExceptionHandler` when building a `GraphQL` instance.

Create a new instance of `SentryInstrumentation` and configure `instrumentation` when building a `GraphQL` instance.

You may want to filter some of the errors by using `beforeSend` or an `EventProcessor` (see <PlatformLink to="/configuration/filtering/">Filters</PlatformLink>).

- To integrate `GraphQL` through `SentryGenericDataFetcherExceptionHandler`, create a new instance, pass the delegate that handles the exception, then configure `defaultDataFetcherExceptionHandler`.

- To integrate `GraphQL` through `SentryInstrumentation`, create a new instance and configure `instrumentation`.

You may want to filter some of the errors by using `beforeSend` or an `EventProcessor` (read more about <PlatformLink to="/configuration/filtering/">Filters</PlatformLink>).

In case you're wondering about setup vs set up - Set up is the verb, so when you're telling someone to "Set up a new instance..." vs. setup, which is a noun, so "your setup process..." :)

Thanks :-)

Hmm this one I'm not sure about. You need to provide both SentryGenericDataFetcherExceptionHandler and SentryInstrumentation after the latest changes.

lizokm · 2023-08-17T20:04:36Z

src/platforms/java/common/configuration/integrations/graphql.mdx

 <Note>

-Capturing transactions requires that you first <PlatformLink to="/performance/">set up performance monitoring</PlatformLink> if you haven't already.
+If you've been using the now deprecated `SentryDataFetcherExceptionHandler`, please upgrade to `SentryGenericDataFetcherExceptionHandler` and also make sure `SentryInstrumentation` is configured to have more exceptions captured, more detailed exceptions, breacrumbs and better hub propagation. You may want to filter some of the errors by using `beforeSend` or an `EventProcessor` (see <PlatformLink to="/configuration/filtering/">Filters</PlatformLink>).


Suggested change

If you've been using the now deprecated `SentryDataFetcherExceptionHandler`, please upgrade to `SentryGenericDataFetcherExceptionHandler` and also make sure `SentryInstrumentation` is configured to have more exceptions captured, more detailed exceptions, breacrumbs and better hub propagation. You may want to filter some of the errors by using `beforeSend` or an `EventProcessor` (see <PlatformLink to="/configuration/filtering/">Filters</PlatformLink>).

The `SentryDataFetcherExceptionHandler` has been deprecated. Please upgrade to `SentryGenericDataFetcherExceptionHandler` and make sure `SentryInstrumentation` is configured to have more exceptions captured, more detailed exceptions, breadcrumbs, and better hub propagation. You may want to filter the errors by using `beforeSend` or an `EventProcessor` (read more about <PlatformLink to="/configuration/filtering/">Filters</PlatformLink>).

This seems like a daunting list of thing to "make sure of..." do you think it's clear to users why they need to do this and how to do it? If not, maybe we can write a separate section about it?

It's just meant as a side note for people who already used our GraphQL integration before the latest changes. This should put them on the right track to upgrade plus some reasons why in case they missed the changelog entry.

src/platforms/java/common/configuration/integrations/graphql.mdx

Co-authored-by: Liza Mock <[email protected]>

Co-authored-by: vivianyentran <[email protected]> Co-authored-by: Steven Eubank <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

* update banner * update date * remove first sentence per Ben * Update src/components/banner.tsx Co-authored-by: Liza Mock <[email protected]> --------- Co-authored-by: Liza Mock <[email protected]>

* adding responses section explaining timeout * Update src/docs/product/integrations/integration-platform/webhooks.mdx Co-authored-by: vivianyentran <[email protected]> * Update src/docs/product/integrations/integration-platform/webhooks.mdx Co-authored-by: vivianyentran <[email protected]> --------- Co-authored-by: vivianyentran <[email protected]>

Profiling team is retiring the "flame chart" term Instead will use Flame Graph and Aggregated Flame Graph in our docs - This makes the terminology more intuitive. -Ash.

Profiling team is retiring the "flame chart" term Instead will use Flame Graph and Aggregated Flame Graph in our docs - This should make the terminology more intuitive.

This adds a small note to the Resolve Issues by Commit section on the Associate Commits page to explain that resolving issues can also be done through PRs in the same way. Page updated: /product/releases/associate-commits/#resolve-issues-by-commit Closes #54525!

A customer recently ran into trouble because they were trying to associate commits using the form `some-repo@123abc` rather than the form `some-org/some-repo@123abc`. Though we do have a note about this in the docs, in the section on releases, it's easy to miss. We also don't mention it at all in the CLI docs. This fixes that by pulling it out into a highlighted note in both places.

Co-authored-by: getsantry[bot] <getsantry[bot]@users.noreply.github.com>

* Add Discord to integration index * Remove random asterisk from slack docs. idk why this was there * Add Discord product docs * style(lint): Auto commit lint changes * Fix Discord links * Make a couple images wider * Move Discord out of integrations and into EA features * Make requested changes * Move discord docs to ea features directory * Change title to Discord Integration --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

…7652) Adds information about the new event dropdown and the new Recommended event.

* Add browser profiling to profiling getting started * Update src/docs/product/profiling/getting-started.mdx

github-actions · 2023-08-18T07:20:00Z

🏷 The following changes will be made to the repository labels

Validating provided labels
Fetching labels from GitHub
Labels are already up to date

adinauer · 2023-08-18T07:21:14Z

I've reworded the "Set up" section a bit. Please let me know if you'd like me to change it and I can send another PR (once I'm back from my vacation). Going to merge this so users can get more up-to-date docs for GraphQL and not wait until I'm back.

adinauer added 2 commits August 9, 2023 07:56

Document SAGP auto install for backend

cf64bc6

Update GraphQL docs for Java SDK

74e7a41

vercel bot deployed to Preview August 16, 2023 07:42 View deployment

more details on why to upgrade

2b175c7

vercel bot deployed to Preview August 16, 2023 07:56 View deployment

Merge branch 'master' into feat/java-graphql

36c155e

adinauer marked this pull request as ready for review August 16, 2023 08:02

adinauer requested a review from a team as a code owner August 16, 2023 08:02

vercel bot deployed to Preview August 16, 2023 08:09 View deployment

adinauer commented Aug 16, 2023

View reviewed changes

src/platforms/java/common/configuration/integrations/graphql.mdx Outdated Show resolved Hide resolved

adinauer commented Aug 16, 2023

View reviewed changes

src/platforms/java/common/configuration/integrations/graphql.mdx Outdated Show resolved Hide resolved

mention filtering

eba40ab

lbloder approved these changes Aug 16, 2023

View reviewed changes

vercel bot deployed to Preview August 16, 2023 13:57 View deployment

lizokm self-requested a review August 16, 2023 23:17

lizokm approved these changes Aug 17, 2023

View reviewed changes

adinauer and others added 13 commits August 18, 2023 08:53

Apply suggestions from code review

ae8e42b

Co-authored-by: Liza Mock <[email protected]>

Apply suggestions from code review

e6b2eff

Co-authored-by: Liza Mock <[email protected]>

style(lint): Auto commit lint changes

3d27d77

style(lint): Auto commit lint changes

80d2b74

Add source maps upload instructions for CRA (#7628)

1959e98

Co-authored-by: vivianyentran <[email protected]> Co-authored-by: Steven Eubank <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

feat(sdk): Upgrade @sentry/gatsby to v7.64.0-alpha.0 (#7644)

5352f77

Add Banner for Upcoming Crons Webinar (#7632)

e6ecbe3

* update banner * update date * remove first sentence per Ben * Update src/components/banner.tsx Co-authored-by: Liza Mock <[email protected]> --------- Co-authored-by: Liza Mock <[email protected]>

Update flame-charts-graphs.mdx (#7656)

ac30cb0

Profiling team is retiring the "flame chart" term Instead will use Flame Graph and Aggregated Flame Graph in our docs - This makes the terminology more intuitive. -Ash.

Update profile-details.mdx (#7658)

0ec40d3

Profiling team is retiring the "flame chart" term Instead will use Flame Graph and Aggregated Flame Graph in our docs - This should make the terminology more intuitive.

Update index.mdx (#7659)

5f5954e

Profiling team is retiring the "flame chart" term Instead will use Flame Graph and Aggregated Flame Graph in our docs - This should make the terminology more intuitive.

hubertdeng123 and others added 7 commits August 18, 2023 08:57

add stale label (#7661)

0b14140

Sync with product-owners.yml in security-as-code@6137c6e6 (#7655)

640de8c

Co-authored-by: getsantry[bot] <getsantry[bot]@users.noreply.github.com>

Add sourcemaps wizard to angular source map guide (#7663)

59e3062

feat(inbound-filters): Add health check explanation (#7649)

a1f5912

Document new issue details event dropdown and the recommended event (#…

a8ad69c

…7652) Adds information about the new event dropdown and the new Recommended event.

Add browser profiling to profiling getting started (#7665)

c2a3c54

* Add browser profiling to profiling getting started * Update src/docs/product/profiling/getting-started.mdx

vercel bot deployed to Preview August 18, 2023 07:06 View deployment

reword set up

4acd04f

adinauer requested review from a team and kamilogorek as code owners August 18, 2023 07:19

style(lint): Auto commit lint changes

95b2f9b

vercel bot deployed to Preview August 18, 2023 07:48 View deployment

adinauer added 3 commits August 18, 2023 10:24

dummy commit to get github ui to refresh

5c63084

revert

41df7ee

Merge branch 'master' into feat/java-graphql

0db0edb

vercel bot deployed to Preview August 18, 2023 08:37 View deployment

adinauer merged commit aae383f into master Aug 18, 2023
7 checks passed

adinauer deleted the feat/java-graphql branch August 18, 2023 08:49

github-actions bot locked and limited conversation to collaborators Sep 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GraphQL docs for Java SDK #7647

Update GraphQL docs for Java SDK #7647

adinauer commented Aug 16, 2023 •

edited

Loading

vercel bot commented Aug 16, 2023 •

edited

Loading

lbloder left a comment

lizokm left a comment

lizokm Aug 17, 2023

adinauer Aug 18, 2023

lizokm Aug 17, 2023

adinauer Aug 18, 2023

github-actions bot commented Aug 18, 2023 •

edited

Loading

adinauer commented Aug 18, 2023

Update GraphQL docs for Java SDK #7647

Update GraphQL docs for Java SDK #7647

Conversation

adinauer commented Aug 16, 2023 • edited Loading

Pre-merge checklist

Description of changes

Legal Boilerplate

Extra resources

vercel bot commented Aug 16, 2023 • edited Loading

lbloder left a comment

Choose a reason for hiding this comment

lizokm left a comment

Choose a reason for hiding this comment

lizokm Aug 17, 2023

Choose a reason for hiding this comment

adinauer Aug 18, 2023

Choose a reason for hiding this comment

lizokm Aug 17, 2023

Choose a reason for hiding this comment

adinauer Aug 18, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2023 • edited Loading

adinauer commented Aug 18, 2023

adinauer commented Aug 16, 2023 •

edited

Loading

vercel bot commented Aug 16, 2023 •

edited

Loading

github-actions bot commented Aug 18, 2023 •

edited

Loading