Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling): update summary docs #8317

Merged
merged 17 commits into from
Nov 20, 2023
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Oct 23, 2023

Updates summary docs for profiling overview - this page should be a lot more easily digestible for users as we try and do a lot of the analysis for them (e.g slowest fns, regressed fns) + an area chart that they should be familiar with at Sentry already

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Nov 20, 2023 1:24pm

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this so quickly!! I've left some wording tweaks. I think it might help to have a few more visuals that go along with the explanation. It might help for us to chat for another 5-10 minutes :)

src/docs/product/profiling/index.mdx Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tweaks.

It would be good to add an Arcade to this section to show the UI interaction in addition to describing it. But we can do that a little bit later.

src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
src/docs/product/profiling/index.mdx Outdated Show resolved Hide resolved
@getsantry
Copy link
Contributor

getsantry bot commented Nov 20, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 20, 2023
@JonasBa JonasBa enabled auto-merge (squash) November 20, 2023 13:13
@JonasBa JonasBa merged commit 60753dd into master Nov 20, 2023
7 of 8 checks passed
@JonasBa JonasBa deleted the jb/profiling/summary-redesign-docs branch November 20, 2023 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants