Update index.mdx #8626
Merged
Update index.mdx #8626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a note to help users who don't know which integration to install
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| <Note> | ||
|
|
||
| If you're not sure which GitHub integration you need to configure, please take a look at the URL. The https://github.com/org-name is usually for GitHub-hosted accounts. The self-hosted GitHub Enterprise accounts typically have URLs that look more like this: https://github.org-name.com (or some other customization of the domain). If that's the case, you should configure the non-Enterprise GitHub integration. |
There was a problem hiding this comment.
Suggested change
| If you're not sure which GitHub integration you need to configure, please take a look at the URL. The https://github.com/org-name is usually for GitHub-hosted accounts. The self-hosted GitHub Enterprise accounts typically have URLs that look more like this: https://github.org-name.com (or some other customization of the domain). If that's the case, you should configure the non-Enterprise GitHub integration. | |
| If you're not sure which GitHub integration you need to configure, please take a look at the URL. URLs like `https://github.com/org-name` are usually for GitHub-hosted accounts and should use the regular GitHub (not GitHub Enterprise) integration. See [Install](#install) for more details. | |
| Self-hosted GitHub Enterprise accounts typically have URLs that look more like `https://github.org-name.com` (or some other customization of the domain). In this case, you should configure the [GitHub Enterprise integration](#github-enterprise). |
The last sentence made it confusing to what you were referring to for the non-enterprise integration, but I think it was the github.com/org-name url? I reworded this and made it two paragraphs for clarity. Feel free to revise if I got it mixed up.
I would also move this note down to after the first sentence of the page (line 20) so it comes up when users need to make a decision.
There was a problem hiding this comment.
hi @vivianyentran this is perfect, thank you! yes, it would also make sense to move this down
Add suggestions
|
I'll go ahead and merge this since it's been a few days :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a note to help users who don't know which integration to install
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources