Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rn): Add React Native Metro Bundler page #8662

Merged
merged 3 commits into from
Dec 15, 2023
Merged

feat(rn): Add React Native Metro Bundler page #8662

merged 3 commits into from
Dec 15, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich requested a review from a team as a code owner December 7, 2023 16:20
@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 6:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 6:30pm

lizokm
lizokm reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thanks for writing this. Shana and I are both not feeling well today, but will look at this as soon as we're better. Thanks for being patient with us!

@krystofwoldrich
Copy link
Member Author

@lizokm Thank you for the message. Get well soon.

lizokm
lizokm reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the prerequisites, troubleshooting and giving users more of an information ramp!!
Made a few language tweaks, but otherwise this looks great!

src/platforms/react-native/manual-setup/metro.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/metro.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/metro.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/metro.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/metro.mdx Outdated Show resolved Hide resolved
lizokm
lizokm approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) December 15, 2023 18:24
@krystofwoldrich krystofwoldrich merged commit e49439c into master Dec 15, 2023
8 of 9 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-rn-add-metro branch December 15, 2023 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lizokm lizokm lizokm approved these changes

@shanamatthews shanamatthews Awaiting requested review from shanamatthews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @lizokm