Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): Query sources #8670

Merged
merged 15 commits into from
Dec 19, 2023
Merged

feat(database): Query sources #8670

merged 15 commits into from
Dec 19, 2023

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Dec 7, 2023

Documentation for the incoming "Query Sources" feature.

Changes

  • Convert queries page to mdx
  • Remove stray breaks
  • First draft

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 3:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 3:55pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments/suggestions but good first draft on this!

src/docs/product/performance/queries.mdx Outdated Show resolved Hide resolved
src/docs/product/performance/queries.mdx Outdated Show resolved Hide resolved
src/docs/product/performance/queries.mdx Show resolved Hide resolved
src/docs/product/performance/queries.mdx Outdated Show resolved Hide resolved
src/docs/product/performance/queries.mdx Show resolved Hide resolved
src/docs/product/performance/queries.mdx Outdated Show resolved Hide resolved
@gggritso
Copy link
Member Author

@vivianyentran did a round of updates! Mostly just accepting your feedback everywhere, but also added a screenshot. How's it looking?

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I'd love more explicit instructions on the threshold configuration

src/docs/product/performance/queries.mdx Outdated Show resolved Hide resolved
src/docs/product/performance/queries.mdx Outdated Show resolved Hide resolved
Co-authored-by: vivianyentran <[email protected]>
gggritso and others added 2 commits December 15, 2023 10:42
Co-authored-by: vivianyentran <[email protected]>
Co-authored-by: vivianyentran <[email protected]>
@gggritso
Copy link
Member Author

@vivianyentran awesome, thank you! I committed your last two suggestions as-is, the links are correct 👍🏻 Does this PR need any other changes?

@vivianyentran
Copy link
Contributor

Looks good to me!!

@gggritso gggritso marked this pull request as ready for review December 15, 2023 20:55
@gggritso gggritso requested a review from a team as a code owner December 15, 2023 20:55
@gggritso gggritso merged commit 29ec571 into master Dec 19, 2023
9 checks passed
@gggritso gggritso deleted the feat/database/query-sources branch December 19, 2023 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants