Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deno): Add basic Deno docs #8674

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 8, 2023

Closes #8608

I copied how Bun was added. This does have some downsides in that it's listed as a browser framework.

Copy link

vercel bot commented Dec 8, 2023

@timfish is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 5:21pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 5:21pm

ingestion domain:

```bash
deno run index.ts --allow-net=___ORG_INGEST_DOMAIN___
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide an example of what ___ORG_INGEST_DOMAIN___ should be?

Copy link
Collaborator Author

@timfish timfish Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those placeholder strings that gets automatically replaced with a dropdown of customer ingest domains!

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man, my bad. Looks good then!

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal that its under browser, but let's get this merged since I think there are larger discussions in place for the browser/node split.

@AbhiPrasad AbhiPrasad merged commit 4af9152 into getsentry:master Dec 12, 2023
9 checks passed
@timfish timfish deleted the feat/add-deno branch December 13, 2023 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno SDK Docs
2 participants