Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Network Error Logging #9151

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Enable Network Error Logging #9151

merged 2 commits into from
Feb 15, 2024

Conversation

oioki
Copy link
Member

@oioki oioki commented Feb 15, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

This feature will allow us to early detect any missing pages. Missing pages (404s) and other network errors will be reported to docs project.

Example of 404 error: https://sentry.sentry.io/issues/4981240586/events/e88ffb8acd114ba39bc4c3f488b4350d/

For now, sampling reports at 5% and policy duration of 1 hour.

@oioki oioki requested a review from a team February 15, 2024 12:45
@oioki oioki requested a review from a team as a code owner February 15, 2024 12:45
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 5:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 5:18pm

@HazAT
Copy link
Member

HazAT commented Feb 15, 2024

Is there a reason we don't put it in the existing project?

@oioki
Copy link
Member Author

oioki commented Feb 15, 2024

Is there a reason we don't put it in the existing project?

No particular reason, just mimicking how CSP reports are collected (also to a separate project).

@HazAT
Copy link
Member

HazAT commented Feb 15, 2024

I would move everything into one project - also CSP and try to use our product so it makes sense.

@oioki oioki merged commit 921ee8a into master Feb 15, 2024
8 checks passed
@oioki oioki deleted the feat/add-nel-headers branch February 15, 2024 17:56
@oioki oioki mentioned this pull request Feb 16, 2024
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants