Fix api/auth route conflict #9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `api/auth` route added for the changelog conflicts with the `api/auth` docs page that would normally be handled by the catchall `[[...path]]` route, causing those doc pages to 404. Since the newly added `api/auth` is used by the changelog, move it under the `changelog` path to fix the route conflict.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
HazAT
approved these changes
Feb 15, 2024
This reverts commit 680c7c4.
Commit 680c7c4 added memoized the fetch for OpenAPI JSON in the `resolveOpenAPI` function, but that particular implementation caused some problems with the build output. Some of the pages in the API section went missing. The previous implementation was susceptible to a bit of a race condition, since the cached value wasn't set until after several async calls. When Next tries to aggressively build pages, multiple calls could have gotten through to do live calls, and then all of them would have tried to set the cache variable. I don't know the exact pathway to the issue but I suspect this had something to do with the missing pages (some sort of data corruption?). Sorry, I know this is handwavy. Anyway, replacing that implementation with a more robust one - one that caches a promise on the first call, and reuses that promise on all future calls - will definitely only fetch once per process. When the fetch completes, everyone waiting on the promise will awaken, and then future callers of the method will get a resolved promise for immediate results. And, most importantly, this method of caching doesn't cause the `api/auth` and `api/guides` pages to go missing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
api/authroute added for the changelog conflicts with theapi/authdocs page that would normally be handled by the catchall[[...path]]route, causing those doc pages to 404.Since the newly added
api/authis used by the changelog, move it under thechangelogpath to fix the route conflict.