-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify on-prem vs. cloud instructions for GitHub Enterprise #9155
Clarify on-prem vs. cloud instructions for GitHub Enterprise #9155
Conversation
@cstavitsky is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: vivianyentran <[email protected]>
…ttps://github.com/cstavitsky/sentry-docs into clarify_github_enterprise_integration_instructions
Just wanted to follow up on this PR as it's still in draft form. Wondering if you're waiting on anything else before merging this? |
Yes, going to see if an engineer who works on integrations can give this a review as well. Following up on that now, will promote from draft to a real PR, but please hold off on merging til I can get an approval there as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@vivianyentran I think we're good to get this merged 👍 Thanks again @schew2381 for the review! |
sounds good! will go ahead and merge this in! |
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Resolves #8665