Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify on-prem vs. cloud instructions for GitHub Enterprise #9155

Conversation

cstavitsky
Copy link
Contributor

@cstavitsky cstavitsky commented Feb 15, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Resolves #8665

Copy link

vercel bot commented Feb 15, 2024

@cstavitsky is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 0:17am

@vivianyentran
Copy link
Contributor

Just wanted to follow up on this PR as it's still in draft form. Wondering if you're waiting on anything else before merging this?

@cstavitsky
Copy link
Contributor Author

Just wanted to follow up on this PR as it's still in draft form. Wondering if you're waiting on anything else before merging this?

Yes, going to see if an engineer who works on integrations can give this a review as well. Following up on that now, will promote from draft to a real PR, but please hold off on merging til I can get an approval there as well

@cstavitsky cstavitsky marked this pull request as ready for review February 20, 2024 21:47
@schew2381 schew2381 self-requested a review February 23, 2024 21:08
Copy link
Contributor

@schew2381 schew2381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cstavitsky
Copy link
Contributor Author

@vivianyentran I think we're good to get this merged 👍 Thanks again @schew2381 for the review!

@vivianyentran
Copy link
Contributor

sounds good! will go ahead and merge this in!

@vivianyentran vivianyentran merged commit fce6cc0 into getsentry:master Feb 23, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Enterprise integration is for GitHub Enterprise Server only (does not include GitHub Enterprise Cloud)
3 participants