Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PowerShell #9198

Merged
merged 11 commits into from
Mar 11, 2024
Merged

feat: PowerShell #9198

merged 11 commits into from
Mar 11, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Feb 21, 2024

This adds new platform: PowerShell

Docs are almost exclusively based on the .NET docs with the reduction of stuff that's not relevant here and some minor changes about how to capture errors.

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

ion of changes

Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Feb 21, 2024

@vaind is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 1:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2024 1:18pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a light review, since I assume most of this content is being reused from the .NET SDKs. Added some comments but otherwise lgtm!

@vivianyentran
Copy link
Contributor

@bitsandfoxes Can you also take a look at this PR to add powershell docs?

@bitsandfoxes
Copy link
Contributor

Looking 👁️

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's so much copy paste now between all platforms. It'll be very hard to keep things consistent as we change each them

docs/platforms/powershell/configuration/draining.mdx Outdated Show resolved Hide resolved

<PlatformContent includePath="configuration/config-intro" />

## Common Options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an include file shared by .NET/Unity/PowerShell?

It's going out of sync quickly otherwise

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, this page is not .net specific, there are actually 18 copies of the same content right now, so any effort to reintegrate should be, IMO, done for all SDKs.

@bitsandfoxes bitsandfoxes enabled auto-merge (squash) March 11, 2024 12:29
@bitsandfoxes bitsandfoxes merged commit 5cb8c88 into getsentry:master Mar 11, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants