Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PlatformOrGuideName and PlatformSdkPackageName components #9200

Merged
merged 2 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/platforms/javascript/common/profiling/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ Note that since the profiling API is currently only exposed in Chromium, profile

To get started with JavaScript browser profiling, you'll need to:

- Install the @sentry/browser SDK, minimum version 7.60.0
- Install the <PlatformSdkPackageName fallback="@sentry/browser"/> SDK, minimum version 7.60.0
- Configure the document response header to include `Document-Policy: js-profiling`
- Configure the SDK to use the `BrowserProfilingIntegration` and set `profilesSampleRate`

## Step 1: Install the JavaScript Browser SDK
## Step 1: Install the <PlatformOrGuideName/> SDK

<PlatformSection notSupported={["javascript.electron"]}>

Install our JavaScript browser SDK using either `yarn` or `npm`, the minimum version that supports profiling is **7.60.0**.
Install our <PlatformOrGuideName/> SDK using either `yarn` or `npm`, the minimum version that supports profiling is **7.60.0**.
Comment on lines +29 to +37
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the concrete use case I want to fix (which was reported by our sales engineers today in Slack).


</PlatformSection>

Expand Down
25 changes: 25 additions & 0 deletions src/components/platformOrGuideName.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import {getCurrentPlatformOrGuide} from 'sentry-docs/docTree';
import {serverContext} from 'sentry-docs/serverContext';

type PlatformOrGuideNameProps = {
/**
* The fallback value to display if the platform or guide name is not found.
* @default 'Sentry'
*/
fallback?: string;
};

/**
* Displays a readable name of the currently selected platform or guide.
* Example: `Next.js`.
*/
export function PlatformOrGuideName({fallback}: PlatformOrGuideNameProps) {
const fallbackName = fallback || 'Sentry';
const {rootNode, path} = serverContext();
const platformOrGuide = rootNode && getCurrentPlatformOrGuide(rootNode, path);
if (!platformOrGuide) {
return 'fallbackName ';
mjq-sentry marked this conversation as resolved.
Show resolved Hide resolved
}

return `${platformOrGuide.title || fallbackName} `;
}
40 changes: 40 additions & 0 deletions src/components/platformSdkPackageName.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import getPackageRegistry from 'sentry-docs/build/packageRegistry';
import {getCurrentPlatformOrGuide} from 'sentry-docs/docTree';
import {serverContext} from 'sentry-docs/serverContext';

type PlatformSdkPackageNameProps = {
/**
* The fallback value to display if the SDK package name is not found.
* @default 'Sentry'
*/
fallback?: string;
};

/**
* Displays the SDK package name for the current platform or guide.
* Example: `@sentry/react`
*/
export async function PlatformSdkPackageName({fallback}: PlatformSdkPackageNameProps) {
const fallbackName = fallback || 'Sentry';
const {rootNode, path} = serverContext();
const platformOrGuide = rootNode && getCurrentPlatformOrGuide(rootNode, path);
if (!platformOrGuide) {
return <code>{fallbackName} </code>;
}

const packageRegistry = await getPackageRegistry();
const allSdks = packageRegistry.data;
const entries = Object.entries(allSdks || {});
const pair: any = entries.find(([sdkName]) => sdkName === platformOrGuide.sdk);
if (!pair) {
return <code>{fallbackName} </code>;
}
const [, sdkData] = pair;
if (!sdkData) {
return <code>{fallbackName} </code>;
}

const prettifiedName = sdkData.canonical.replace(/^npm:/, '');

return <code>{prettifiedName || fallbackName} </code>;
}
4 changes: 4 additions & 0 deletions src/mdxComponents.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import {PlatformGrid} from './components/platformGrid';
import {PlatformIdentifier} from './components/platformIdentifier';
import {PlatformLink} from './components/platformLink';
import {PlatformLinkWithLogo} from './components/platformLinkWithLogo';
import {PlatformOrGuideName} from './components/platformOrGuideName';
import {PlatformSdkPackageName} from './components/platformSdkPackageName';
import {PlatformSection} from './components/platformSection';
import {RelayMetrics} from './components/relayMetrics';
import {SandboxLink} from './components/sandboxLink';
Expand Down Expand Up @@ -55,6 +57,8 @@ export function mdxComponents(
PlatformLink,
PlatformLinkWithLogo,
PlatformSection,
PlatformOrGuideName,
PlatformSdkPackageName,
RelayMetrics,
SandboxLink,
SignInNote,
Expand Down
Loading