Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap headers in links and adjust header icons styles #9303

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Mar 2, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

My first attempt at this caused a visual regression. Hopefully everything looks good now

Addresses #9218

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 2:11pm

@a-hariti a-hariti requested a review from kahest March 2, 2024 13:50
Copy link

codecov bot commented Mar 2, 2024

Bundle Report

Changes will increase total bundle size by 468 bytes ⬆️

Bundle name Size Change
sentry-docs-server 5.93MB 426 bytes ⬆️
sentry-docs-edge-server 3.47kB 0 bytes
sentry-docs-client 5.51MB 42 bytes ⬆️

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Didn't find any issues anymore, all usages of <ConfigKey> seem to work fine now 👍

@a-hariti
Copy link
Collaborator Author

a-hariti commented Mar 4, 2024

I tried to introduce a minimal diff to avoid disruption @kahest

@lizokm lizokm merged commit cc067b9 into master Mar 4, 2024
8 checks passed
@lizokm lizokm deleted the heading-links-2 branch March 4, 2024 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants