-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: New Electron versions #658
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
3 times, most recently
from
April 5, 2023 09:04
0afab18
to
be2e677
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
3 times, most recently
from
April 14, 2023 09:04
2b4e7ef
to
713ce62
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
from
April 15, 2023 09:04
713ce62
to
a5be1fc
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
from
April 18, 2023 09:04
a5be1fc
to
497e780
Compare
It looks like there are differences between the reported spans for browser tracing with the Chrome upgrade from v110 to v112: v110: "spans": [
{
"description": "domContentLoadedEvent",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp": 0,
"trace_id": "{{id}}"
},
{
"description": "loadEvent",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp": 0,
"trace_id": "{{id}}"
},
{
"description": "connect",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp": 0,
"trace_id": "{{id}}"
},
{
"description": "cache",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp":0,
"trace_id": "{{id}}"
},
{
"description": "DNS",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp": 0,
"trace_id": "{{id}}"
},
{
"description": "request",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp": 0,
"trace_id": "{{id}}"
},
{
"description": "response",
"op": "browser",
"parent_span_id": "{{id}}",
"span_id": "{{id}}",
"start_timestamp": 0,
"timestamp": 0,
"trace_id": "{{id}}"
}
], v112: spans: [
{
description: 'Main UI thread blocked',
op: 'ui.long-task',
parent_span_id: '8d6a5ae668733c6d',
span_id: '93241f09d2621a7a',
start_timestamp: 1681806048.956,
timestamp: 1681806049.072,
trace_id: '4311ef6bf2354989a2f32816004da27b'
},
{
description: 'Main UI thread blocked',
op: 'ui.long-task',
parent_span_id: '8d6a5ae668733c6d',
span_id: 'a7e767fd23fd8c26',
start_timestamp: 1681806049.0751002,
timestamp: 1681806049.1641002,
trace_id: '4311ef6bf2354989a2f32816004da27b'
},
{
description: 'sentry-tracing-init',
op: 'mark',
parent_span_id: '8d6a5ae668733c6d',
span_id: '8801afa9[581](https://github.com/getsentry/sentry-electron/actions/runs/4730166925/jobs/8393552886?pr=658#step:5:582)29ba8',
start_timestamp: 1681806049.1551,
timestamp: 1681806049.1551,
trace_id: '4311ef6bf2354989a2f32816004da27b'
}
], |
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
from
April 19, 2023 09:04
497e780
to
da6ae40
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
2 times, most recently
from
April 27, 2023 09:04
242133b
to
266025e
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
2 times, most recently
from
May 11, 2023 09:04
fb62f72
to
359ae84
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
2 times, most recently
from
May 25, 2023 09:04
c301535
to
0642182
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
2 times, most recently
from
May 30, 2023 09:04
29b8a39
to
8ab7b77
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
from
June 1, 2023 09:04
8ab7b77
to
a76448b
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
3 times, most recently
from
June 14, 2023 09:04
1a27a2b
to
800df26
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
2 times, most recently
from
June 22, 2023 09:04
aab114f
to
0b887f4
Compare
github-actions
bot
force-pushed
the
test/new-electron-versions
branch
from
June 29, 2023 09:04
0b887f4
to
910ca3d
Compare
Closing in favour of #689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generated PR to test new Electron releases