Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: New Electron versions #658

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Automatically generated PR to test new Electron releases

@github-actions github-actions bot force-pushed the test/new-electron-versions branch 3 times, most recently from 0afab18 to be2e677 Compare April 5, 2023 09:04
@github-actions github-actions bot force-pushed the test/new-electron-versions branch 3 times, most recently from 2b4e7ef to 713ce62 Compare April 14, 2023 09:04
@timfish timfish closed this Apr 14, 2023
@timfish timfish reopened this Apr 14, 2023
@timfish timfish closed this Apr 18, 2023
@timfish timfish reopened this Apr 18, 2023
@timfish
Copy link
Collaborator

timfish commented Apr 18, 2023

It looks like there are differences between the reported spans for browser tracing with the Chrome upgrade from v110 to v112:

v110:

    "spans": [
      {
        "description": "domContentLoadedEvent",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp": 0,
        "trace_id": "{{id}}"
      },
      {
        "description": "loadEvent",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp": 0,
        "trace_id": "{{id}}"
      },
      {
        "description": "connect",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp": 0,
        "trace_id": "{{id}}"
      },
      {
        "description": "cache",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp":0,
        "trace_id": "{{id}}"
      },
      {
        "description": "DNS",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp": 0,
        "trace_id": "{{id}}"
      },
      {
        "description": "request",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp": 0,
        "trace_id": "{{id}}"
      },
      {
        "description": "response",
        "op": "browser",
        "parent_span_id": "{{id}}",
        "span_id": "{{id}}",
        "start_timestamp": 0,
        "timestamp": 0,
        "trace_id": "{{id}}"
      }
    ],

v112:

spans: [
      {
        description: 'Main UI thread blocked',
        op: 'ui.long-task',
        parent_span_id: '8d6a5ae668733c6d',
        span_id: '93241f09d2621a7a',
        start_timestamp: 1681806048.956,
        timestamp: 1681806049.072,
        trace_id: '4311ef6bf2354989a2f32816004da27b'
      },
      {
        description: 'Main UI thread blocked',
        op: 'ui.long-task',
        parent_span_id: '8d6a5ae668733c6d',
        span_id: 'a7e767fd23fd8c26',
        start_timestamp: 1681806049.0751002,
        timestamp: 1681806049.1641002,
        trace_id: '4311ef6bf2354989a2f32816004da27b'
      },
      {
        description: 'sentry-tracing-init',
        op: 'mark',
        parent_span_id: '8d6a5ae668733c6d',
        span_id: '8801afa9[581](https://github.com/getsentry/sentry-electron/actions/runs/4730166925/jobs/8393552886?pr=658#step:5:582)29ba8',
        start_timestamp: 1681806049.1551,
        timestamp: 1681806049.1551,
        trace_id: '4311ef6bf2354989a2f32816004da27b'
      }
    ],

@github-actions github-actions bot force-pushed the test/new-electron-versions branch 2 times, most recently from 242133b to 266025e Compare April 27, 2023 09:04
@github-actions github-actions bot force-pushed the test/new-electron-versions branch 2 times, most recently from fb62f72 to 359ae84 Compare May 11, 2023 09:04
@github-actions github-actions bot force-pushed the test/new-electron-versions branch 2 times, most recently from c301535 to 0642182 Compare May 25, 2023 09:04
@github-actions github-actions bot force-pushed the test/new-electron-versions branch 2 times, most recently from 29b8a39 to 8ab7b77 Compare May 30, 2023 09:04
@timfish timfish closed this May 31, 2023
@timfish timfish reopened this May 31, 2023
@github-actions github-actions bot force-pushed the test/new-electron-versions branch from 8ab7b77 to a76448b Compare June 1, 2023 09:04
@timfish timfish closed this Jun 6, 2023
@timfish timfish reopened this Jun 6, 2023
@github-actions github-actions bot force-pushed the test/new-electron-versions branch 3 times, most recently from 1a27a2b to 800df26 Compare June 14, 2023 09:04
@github-actions github-actions bot force-pushed the test/new-electron-versions branch 2 times, most recently from aab114f to 0b887f4 Compare June 22, 2023 09:04
@timfish timfish closed this Jun 29, 2023
@timfish timfish reopened this Jun 29, 2023
@timfish
Copy link
Collaborator

timfish commented Jun 29, 2023

Closing in favour of #689

@timfish timfish closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant