Retain newest breadcrumbs (instead of oldest)

getsentry · Feb 10, 2025 · 3b3ff64 · 3b3ff64
1 parent ce93ed4
commit 3b3ff64
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/sentry/context.ex b/lib/sentry/context.ex
@@ -423,8 +423,7 @@ defmodule Sentry.Context do
     sentry_metadata =
       get_sentry_context()
       |> Map.update(@breadcrumbs_key, [map], fn breadcrumbs ->
-        breadcrumbs = [map | breadcrumbs]
-        Enum.take(breadcrumbs, -1 * Sentry.Config.max_breadcrumbs())
+        Enum.take([map | breadcrumbs], Sentry.Config.max_breadcrumbs())
       end)
 
     :logger.update_process_metadata(%{@logger_metadata_key => sentry_metadata})

diff --git a/test/context_test.exs b/test/context_test.exs
@@ -39,6 +39,16 @@ defmodule Sentry.ContextTest do
     assert first_breadcrumb.timestamp <= second_breadcrumb.timestamp
   end
 
+  test "retains most recent breadcrumbs when exceeding max" do
+    put_test_config(max_breadcrumbs: 3)
+
+    for x <- 1..10, do: Context.add_breadcrumb(message: x)
+
+    event = Event.create_event([])
+
+    assert event.breadcrumbs |> Enum.map(& &1.message) == [8, 9, 10]
+  end
+
   test "storing user context appears when generating event" do
     Context.set_user_context(%{id: "345"})