Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Run unit tests in CI #37

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

limbonaut
Copy link
Collaborator

@limbonaut limbonaut commented Nov 29, 2024

Run unit tests in CI using Windows and Linux runners. This will help us detect compilation and runtime issues early on.

@limbonaut limbonaut added enhancement New feature or request github-actions labels Nov 29, 2024
@limbonaut limbonaut force-pushed the gha/ci-run-tests branch 2 times, most recently from 763b205 to 55c2013 Compare December 4, 2024 17:14
@limbonaut limbonaut marked this pull request as ready for review December 5, 2024 11:10
@limbonaut
Copy link
Collaborator Author

ea10f3f should be dropped before merge

@limbonaut limbonaut linked an issue Dec 5, 2024 that may be closed by this pull request
@limbonaut
Copy link
Collaborator Author

@bitsandfoxes @bruno-garcia
Good to merge? It's still waiting for approval.

Copy link

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

- name: Run tests
shell: bash
timeout-minutes: 5
run: |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this step fails if the tests fail?

Copy link
Collaborator Author

@limbonaut limbonaut Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about timeout-minutes - docs don't specify if it fails the step. Need to check it. (Works as expected).
According to docs, the process should return:

0   = all tests success
100 = ends with test failures
101 = ends with test warnings

@limbonaut limbonaut force-pushed the gha/ci-run-tests branch 3 times, most recently from bb09127 to 3abd66f Compare December 11, 2024 16:26
@limbonaut limbonaut merged commit 08b0f61 into getsentry:main Dec 11, 2024
8 checks passed
@limbonaut limbonaut deleted the gha/ci-run-tests branch December 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute GDScript-based unit tests in CI
3 participants