-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Spring Boot to 3.4 #3941
Comments
Please see this issue as this might very well pertain to Sentry: spring-projects/spring-boot#43332 Using Sentry 7.18.1 and 8.0.0.rc1 produced different errors in our staging environment.
Cannot confirm 💯 without disabling Sentry in our Spring Boot app completely but have a Cheers, |
Thanks for reaching out @bjornharvold , what makes you think it's Sentry that's causing the issues? Just using different versions and having different outcomes? Are you seeing any exceptions? Do you have a repro we can use to look into this issue? Can you please share more info on how you're using Sentry (which SDK, integrations, options, etc.). |
Hi @adinauer What makes this look like an instrumentation issue, is that there is 0 errors. The apps just start hanging completely and being completely unresponsive even though we can see Spring Data MongoDb pinging MongoDB Atlas every few seconds. Now it could be Spring Authorization Server but it wouldn't be giving us different errors based on the Sentry version we use. Never seen anything quite like this actually. Of course cannot be sure it's Sentry as we are unable to make a thread dump once the Cloud Run instance reaches this state. Last indication that it is most likely Sentry is that our Spring Boot app (3.4.0) works locally and we have set Hope this helps, |
@bjornharvold did this start happening when you bumped Spring Boot to Can you please share more details on what Sentry integrations you're using and what config options you are setting? How many servers are in play here and which one is causing troubles? A reproducible sample would be the best way for us to help you. |
Hi @adinauer, This started happening when upgrading Spring Boot to 3.4.0 and pushing to staging. Sentry was still on 7.18.0 at this point. Here are the settings we use in staging and we haven't changed these settings for a long time (This is the configuration for a Spring Web MVC app FYI - maybe the reactive and backpressue properties are not valid here): I am not asking for support on this ticket. I will create my own if I am certain that it's Sentry. Pointing out that this might be something to look at while testing support for Spring Boot 3.4.0. In your docs, there is no support for this version yet AFAIK. |
@bjornharvold can you please try with |
@bjornharvold have you had a chance to test the config change above? The problem might be related to us caching the request body. The suggested config disables attaching the request body to Sentry events as well as temporary caching of the request body. |
Hi @adinauer Will try this next week when staging frees up. Cheers |
@bjornharvold your initial properties of
should now work with
This issue should now be fixed. |
Hi @adinauer, I can confirm that rc.3 does not freeze our server and authentication with SAS works fine. 👏🏻🦸♂️ |
Hi Team, There is still something going on with one of our apps that uses Apache CXF with Spring Web Services. Looking into it. |
Latest update, we released a build to our production servers with Spring Boot 3.4.1 and Sentry 8.0.0.rc-3.
Wondering if there is a memory leak or memory requirements changed with either Spring Boot or Sentry. Thoughts on how to better verify this. Cannot test this in a production environment due to unhappy customers 😉 |
Here's the only thing we have to go on at the present moment:
|
Hey, in Sentry v8 a lot has changed, but so far there's no other reports of memory leaks. Do you happen to have a heap dump that you can analyze? How much memory do you have available? Do you have some memory stats from before and after upgrading? I'll do some more testing and report back here. |
Hi @adinauer
Next we will disable Sentry completely to make 100% sure that this is a Sentry issue and not something else. |
We just made a release with setting sentry.enabled=false in our production environment. We did not remove the Sentry Spring Boot starter dependency FYI. The apps still freeze. So this is possibly not a Sentry issue after all. Happy New Year 🎆 |
Thanks for the update. Please let us know if you need more help from us. |
@bjornharvold any news regarding whether the issue goes away when removing Sentry completely from your application? |
Hi @adinauer We only disabled Sentry and upgraded to Spring Boot 3.4.0. The apps hung [in production / not staging]. Assuming Sentry is not involved at this point but some other memory related issue. Holding off with 3.4.0 upgrade until we have more cycles to test. Busy ATM with new features and we cannot have the production servers go down every time we test. Really sucks that we can't get thread / heap dump from GCP Cloud Run. 🫤 |
Thanks for the update. Very understandable. No rush from our side here. We'll consider things stable for now then. Please let us know if you have any further updates. |
Description
Bump Spring Boot to 3.4
The text was updated successfully, but these errors were encountered: