Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Spring Boot to 3.4.0 #3939

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Bump Spring Boot to 3.4.0 #3939

merged 8 commits into from
Dec 2, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 29, 2024 •
edited
Loading

#skip-changelog

📜 Description

Bump Spring Boot to 3.4.0

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f1f28bb

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 437.42 ms 460.76 ms 23.34 ms
Size 1.65 MiB 2.31 MiB 676.04 KiB

Previous results on branch: feat/bump-spring-boot-3-4

Startup times

Revision Plain With Sentry Diff
46cf3fe 375.40 ms 431.39 ms 55.99 ms
ad1087f 488.02 ms 495.50 ms 7.48 ms

App size

Revision Plain With Sentry Diff
46cf3fe 1.65 MiB 2.31 MiB 676.04 KiB
ad1087f 1.65 MiB 2.31 MiB 676.03 KiB

Base automatically changed from feat/otel-storage-provider to 8.x.x November 29, 2024 12:38
adinauer
adinauer commented Dec 2, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -20,6 +20,10 @@

- Fix testTag not working for Jetpack Compose user interaction tracking ([#3878](https://github.com/getsentry/sentry-java/pull/3878))

### Dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix changelog

@adinauer
Copy link
Member Author

adinauer commented Dec 2, 2024 •
edited
Loading

While we haven't found issues with Spring Boot 3.4 compatibility ourselves, a customer has reported something in #3941 (comment)

Let's announce 3.4 support after investigating the linked issue.

@adinauer
Copy link
Member Author

adinauer commented Dec 2, 2024

Failing test is fixed in https://github.com/getsentry/sentry-java/pull/3942/files#diff-7470318d6d4329b98262e020c5aaa478d4f68a00b0ced13309785eccbf5bf685R199

lbloder
lbloder approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit 06f9e9c into 8.x.x Dec 2, 2024
27 of 30 checks passed
@adinauer adinauer deleted the feat/bump-spring-boot-3-4 branch December 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @lbloder