-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tracestate header with baggage #2078
Conversation
sentry-android-core/src/test/java/io/sentry/android/core/ActivityLifecycleIntegrationTest.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2078 +/- ##
============================================
- Coverage 81.11% 80.93% -0.18%
- Complexity 3232 3254 +22
============================================
Files 230 231 +1
Lines 11850 11950 +100
Branches 1572 1586 +14
============================================
+ Hits 9612 9672 +60
- Misses 1652 1698 +46
+ Partials 586 580 -6
Continue to review full report at Codecov.
|
FYI @brustolin |
@AbhiPrasad and @jan-auer could you please take a quick look at the sections / comments I marked with 👀 ? |
…tsentry/sentry-java into feat/replace-trace-state-with-baggage
moved to code, so discussion can be more easily threaded |
sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
…tsentry/sentry-java into feat/replace-trace-state-with-baggage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits only:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good place to start!
@ApiStatus.Experimental | ||
public final class Baggage { | ||
|
||
static final @NotNull String CHARSET = StandardCharsets.UTF_8.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adinauer this is not supported on Android.
We have to private static final Charset UTF_8 = Charset.forName("UTF-8");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to do #1403 to avoid such issues, a simple and empty project already helps, set to API 16
📜 Description
Replace
tracestate
header withbaggage
header.💡 Motivation and Context
Baggage (8192 chars) has a larger size limit than tracestate (256 chars).
💚 How did you test it?
Unit Tests
📝 Checklist
🔮 Next steps