Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove userId from baggage due to PII #2157

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 8, 2022

📜 Description

Remove userId from baggage due to PII

💡 Motivation and Context

getsentry/team-mobile#23 (comment)

💚 How did you test it?

Commented out tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #2157 (1c36665) into main (d948fcf) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2157      +/-   ##
============================================
- Coverage     80.94%   80.91%   -0.03%     
+ Complexity     3290     3287       -3     
============================================
  Files           233      233              
  Lines         12044    12042       -2     
  Branches       1594     1594              
============================================
- Hits           9749     9744       -5     
- Misses         1712     1715       +3     
  Partials        583      583              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/TraceContext.java 84.75% <ø> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efabc19...1c36665. Read the comment docs.

@marandaneto
Copy link
Contributor Author

getsentry/develop#635 has to be addressed which means reverting the transaction changes.

@marandaneto marandaneto changed the title Remove userId and transaction from baggage due to PII Remove userId from baggage due to PII Jul 11, 2022
@marandaneto
Copy link
Contributor Author

#2157 (comment) is adressed.

@marandaneto marandaneto merged commit a0a0b15 into main Jul 11, 2022
@marandaneto marandaneto deleted the chore/remove-tr-userid branch July 11, 2022 08:28
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 11, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 12, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 12, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 12, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 13, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 13, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
felixklauke added a commit to felixklauke/sentry-java that referenced this pull request Jul 14, 2022
Remove userId from baggage due to PII (getsentry#2157)

Rnemae jose dependency config name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants