-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect slow and frozen frames as measurements #3155
Collect slow and frozen frames as measurements #3155
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5344734 | 417.38 ms | 478.70 ms | 61.32 ms |
08b5e20 | 379.47 ms | 438.79 ms | 59.32 ms |
7b303a4 | 381.72 ms | 445.56 ms | 63.84 ms |
243f1a4 | 405.48 ms | 474.32 ms | 68.84 ms |
a5e1504 | 379.98 ms | 463.29 ms | 83.31 ms |
bcb9633 | 443.16 ms | 544.86 ms | 101.70 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5344734 | 1.72 MiB | 2.27 MiB | 558.34 KiB |
08b5e20 | 1.70 MiB | 2.27 MiB | 584.58 KiB |
7b303a4 | 1.72 MiB | 2.27 MiB | 558.34 KiB |
243f1a4 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
a5e1504 | 1.72 MiB | 2.27 MiB | 558.86 KiB |
bcb9633 | 1.70 MiB | 2.27 MiB | 584.62 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So spans do not support explicit measurements (not from the data bag) yet? It's gonna be available with only-spans, right?
* Interpolate total frame count to match span duration * Update Changelog
It looks like it's actually possible, but as far as I can see no SDK has it implemented yet => getsentry/team-mobile#172 |
* Extend performance collector APIs * Update changelog * Update changelog * Collect slow and frozen frames for spans (#3111) * Collect slow and frozen frames using SentryFrameMetricsCollector and SpanFrameMetricsCollector * Rename fast frame to normal frame, remove fastFrameDuration * Extend performance collector APIs * Update changelog * Collect slow and frozen frames using SentryFrameMetricsCollector and SpanFrameMetricsCollector * Rename fast frame to normal frame, remove fastFrameDuration * Fix PR feedback * Fix nullability and remove unused field * Rename FrameMetrics to SentryFrameMetrics * Collect delay instead of total duration * Fix tests * Revert "Fix tests" This reverts commit 5b9c3c6. * Properly fix tests * Collect slow and frozen frames as measurements (#3155) * Ensure slow and frozen frames values are reported as measurement values as well * Interpolate total frame count to match span duration (#3158) * Interpolate total frame count to match span duration * Update Changelog
📜 Description
Similar to
sentry-java/sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesTracker.java
Lines 161 to 172 in a45911f
💡 Motivation and Context
#skip-changelog
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps