Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace op with auto generated content for OpenTelemetry spans with span kindINTERNAL #3906

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

adinauer
Copy link
Member

📜 Description

Disabled auto op generation based on span kind. We only do it if it's something other than INTERNAL.

💡 Motivation and Context

Solution 5b from #3904

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 52049e9

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.69 ms 441.04 ms 37.35 ms
Size 1.65 MiB 2.31 MiB 673.46 KiB

@adinauer adinauer changed the title Automatically create op from span attributes conditionally 5b Do not replace op with auto generated content for OpenTelemetry spans with span kindINTERNAL Nov 21, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@adinauer adinauer marked this pull request as ready for review November 21, 2024 04:50
@adinauer adinauer merged commit 92518a2 into 8.x.x Nov 21, 2024
36 checks passed
@adinauer adinauer deleted the feat/op-from-span-attributes-conditionally-5b branch November 21, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants