Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send otel.kind to Sentry #3907

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Send otel.kind to Sentry #3907

merged 3 commits into from
Nov 20, 2024

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

Closes #3901

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Send `otel.kind` to Sentry ([#3907](https://github.com/getsentry/sentry-java/pull/3907))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 7cb9c3d

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 453.17 ms 484.17 ms 31.00 ms
Size 1.65 MiB 2.31 MiB 673.46 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit b283b32 into 8.x.x Nov 20, 2024
3 of 4 checks passed
@adinauer adinauer deleted the feat/report-span-kind branch November 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants