Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update otel readme files #3978

Merged
merged 18 commits into from
Jan 21, 2025
Merged

update otel readme files #3978

merged 18 commits into from
Jan 21, 2025

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Dec 10, 2024

#skip-changelog

📜 Description

Update readmes for opentelemetry

💡 Motivation and Context

Fixes #3963

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cbececc

@lbloder lbloder changed the title [WIP] update otel sample readme [WIP] update otel readme files Dec 10, 2024
@lbloder lbloder changed the title [WIP] update otel readme files update otel readme files Jan 7, 2025
@lbloder lbloder marked this pull request as ready for review January 7, 2025 15:26
Base automatically changed from 8.x.x to main January 9, 2025 15:47
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some minor suggestions.

sentry-opentelemetry/README.md Outdated Show resolved Hide resolved
sentry-opentelemetry/README.md Outdated Show resolved Hide resolved
sentry-opentelemetry/README.md Outdated Show resolved Hide resolved
sentry-opentelemetry/sentry-opentelemetry-agent/README.md Outdated Show resolved Hide resolved
@adinauer adinauer merged commit d0cb6e4 into main Jan 21, 2025
36 checks passed
@adinauer adinauer deleted the feat/update-otel-sample-readme branch January 21, 2025 15:17
lcian pushed a commit that referenced this pull request Jan 22, 2025
* update readmes for noagent samples, add otel properties to application.properties in noagent samples

* update readme for console - noagent

* update opentelemetry and optentelemetry agent readme

* add java options and new agentless module to readme

* update readmes

* Update sentry-opentelemetry/README.md

Co-authored-by: Alexander Dinauer <[email protected]>

* Update sentry-opentelemetry/README.md

Co-authored-by: Alexander Dinauer <[email protected]>

* Update sentry-opentelemetry/sentry-opentelemetry-agent/README.md

Co-authored-by: Alexander Dinauer <[email protected]>

* Update sentry-opentelemetry/sentry-opentelemetry-agentless/README.md

Co-authored-by: Alexander Dinauer <[email protected]>

* Update sentry-opentelemetry/README.md

Co-authored-by: Alexander Dinauer <[email protected]>

* remove experimental note in opentelemetry readmes

---------

Co-authored-by: Alexander Dinauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenTelemetry README files
2 participants