-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update otel readme files #3978
Merged
Merged
update otel readme files #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lbloder
changed the title
[WIP] update otel sample readme
[WIP] update otel readme files
Dec 10, 2024
7 tasks
lbloder
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
January 7, 2025 15:27
adinauer
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, some minor suggestions.
sentry-opentelemetry/sentry-opentelemetry-agentless-spring/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Dinauer <[email protected]>
Co-authored-by: Alexander Dinauer <[email protected]>
Co-authored-by: Alexander Dinauer <[email protected]>
Co-authored-by: Alexander Dinauer <[email protected]>
Co-authored-by: Alexander Dinauer <[email protected]>
…/sentry-java into feat/update-otel-sample-readme
lcian
pushed a commit
that referenced
this pull request
Jan 22, 2025
* update readmes for noagent samples, add otel properties to application.properties in noagent samples * update readme for console - noagent * update opentelemetry and optentelemetry agent readme * add java options and new agentless module to readme * update readmes * Update sentry-opentelemetry/README.md Co-authored-by: Alexander Dinauer <[email protected]> * Update sentry-opentelemetry/README.md Co-authored-by: Alexander Dinauer <[email protected]> * Update sentry-opentelemetry/sentry-opentelemetry-agent/README.md Co-authored-by: Alexander Dinauer <[email protected]> * Update sentry-opentelemetry/sentry-opentelemetry-agentless/README.md Co-authored-by: Alexander Dinauer <[email protected]> * Update sentry-opentelemetry/README.md Co-authored-by: Alexander Dinauer <[email protected]> * remove experimental note in opentelemetry readmes --------- Co-authored-by: Alexander Dinauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Update readmes for opentelemetry
💡 Motivation and Context
Fixes #3963
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps