Skip to content

[WIP] test with spring boot 3.5.0 #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,10 @@ If you would like to keep some of the default broadcast events as breadcrumbs, c
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0719)
- [diff](https://github.com/getsentry/sentry-native/compare/v0.7.14...0.7.19)

### Dependencies

- Bump Spring Boot to `3.4.2` ([#4081](https://github.com/getsentry/sentry-java/pull/4081))

## 8.0.0

### Summary
Expand Down
2 changes: 2 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ plugins {
buildscript {
repositories {
google()
maven(url = "https://repo.spring.io/milestone")
}
dependencies {
classpath(Config.BuildPlugins.androidGradle)
Expand Down Expand Up @@ -82,6 +83,7 @@ allprojects {
google()
mavenCentral()
mavenLocal()
maven(url = "https://repo.spring.io/milestone")
}
group = Config.Sentry.group
version = properties[Config.Sentry.versionNameProp].toString()
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/Config.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ object Config {
val kotlinStdLib = "stdlib-jdk8"

val springBootVersion = "2.7.18"
val springBoot3Version = "3.4.2"
val springBoot3Version = "3.5.0-RC1"
val kotlinCompatibleLanguageVersion = "1.6"

// see https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-compatibility-and-versioning.html#kotlin-compatibility
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public TaskCreatorController(final BatchLoaderRegistry batchLoaderRegistry) {
// using mapped BatchLoader to not have to deal with correct ordering of items
batchLoaderRegistry
.forTypePair(String.class, ProjectController.Creator.class)
.withOptions((builder) -> builder.setBatchingEnabled(true))
.registerMappedBatchLoader(
(Set<String> keys, BatchLoaderEnvironment env) -> {
return Mono.fromCallable(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public BatchLoaderRegistry.RegistrationSpec<K, V> withName(String name) {

@Override
public BatchLoaderRegistry.RegistrationSpec<K, V> withOptions(
Consumer<DataLoaderOptions> optionsConsumer) {
Consumer<DataLoaderOptions.Builder> optionsConsumer) {
return delegate.withOptions(optionsConsumer);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package io.sentry.spring.graphql
package io.sentry.spring.jakarta.graphql

import graphql.execution.instrumentation.parameters.InstrumentationFieldFetchParameters
import graphql.language.Document
import graphql.language.OperationDefinition
import graphql.schema.DataFetchingEnvironment
import io.sentry.IScopes
import io.sentry.graphql.ExceptionReporter
import io.sentry.spring.jakarta.graphql.SentrySpringSubscriptionHandler
import org.junit.jupiter.api.assertThrows
import org.mockito.kotlin.anyOrNull
import org.mockito.kotlin.check
import org.mockito.kotlin.mock
import org.mockito.kotlin.same
import org.mockito.kotlin.verify
Expand Down Expand Up @@ -40,10 +40,10 @@ class SentrySpringSubscriptionHandlerTest {

verify(exceptionReporter).captureThrowable(
same(exception),
org.mockito.kotlin.check {
check {
assertEquals(true, it.isSubscription)
assertSame(scopes, it.scopes)
assertEquals("query testQuery\n", it.query)
assertEquals("query testQuery \n", it.query)
},
anyOrNull()
)
Expand All @@ -69,10 +69,10 @@ class SentrySpringSubscriptionHandlerTest {

verify(exceptionReporter).captureThrowable(
same(exception),
org.mockito.kotlin.check {
check {
assertEquals(true, it.isSubscription)
assertSame(scopes, it.scopes)
assertEquals("query testQuery\n", it.query)
assertEquals("query testQuery \n", it.query)
},
anyOrNull()
)
Expand Down
1 change: 1 addition & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ pluginManagement {
repositories {
mavenCentral()
gradlePluginPortal()
maven(url = "https://repo.spring.io/milestone")
}
}

Expand Down
Loading