Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop device name #4179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop device name #4179

wants to merge 2 commits into from

Conversation

markushi
Copy link
Member

📜 Description

This is the custom user-defined name device name (e.g. "Markus Pixel Device"), I don't see any good reason why we would collect this, even if PII collecting is enabled.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 436.78 ms 530.52 ms 93.74 ms
Size 1.58 MiB 2.21 MiB 640.87 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2c78de 415.28 ms 505.08 ms 89.80 ms

App size

Revision Plain With Sentry Diff
c2c78de 1.58 MiB 2.21 MiB 640.27 KiB

Previous results on branch: markushi/feat/drop-device-name

Startup times

Revision Plain With Sentry Diff
fdc6fc1 408.96 ms 518.10 ms 109.14 ms

App size

Revision Plain With Sentry Diff
fdc6fc1 1.58 MiB 2.21 MiB 640.88 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants