Skip to content

[Logs 4] Send logs in batches #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

[Logs 4] Send logs in batches #4378

merged 5 commits into from
May 13, 2025
+213 −24

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented May 8, 2025 •
edited
Loading

#skip-changelog

📜 Description

Instead of sending each log event on its own immediately, we now batch them and send after 5s.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d72ee11

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.35 ms 411.79 ms 18.44 ms
Size 1.58 MiB 2.08 MiB 509.36 KiB

Previous results on branch: feat/log-batching

Startup times

Revision Plain With Sentry Diff
8dfe00c 448.32 ms 496.24 ms 47.92 ms

App size

Revision Plain With Sentry Diff
8dfe00c 1.58 MiB 2.08 MiB 508.55 KiB

lcian
lcian approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but I think someone else should double check the baggage logic.

lbloder
lbloder approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer changed the title Send logs in batches [Logs 4] Send logs in batches May 12, 2025
Base automatically changed from feat/logs-options to main May 13, 2025 12:41
@adinauer adinauer merged commit 55564f6 into main May 13, 2025
33 of 35 checks passed
@adinauer adinauer deleted the feat/log-batching branch May 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@stefanosiano stefanosiano stefanosiano approved these changes

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adinauer @lbloder @stefanosiano @lcian