-
-
Notifications
You must be signed in to change notification settings - Fork 459
[ANR] Reduced AndroidTransactionProfiler lock #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
d364ace | 411.72 ms | 430.81 ms | 19.10 ms |
ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
806307f | 357.85 ms | 424.64 ms | 66.79 ms |
ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
b3d8889 | 371.69 ms | 432.96 ms | 61.26 ms |
7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
b3d8889 | 1.58 MiB | 2.10 MiB | 535.06 KiB |
7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
} | ||
} | ||
|
||
boolean isRunning() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't looked at the entire PR yet, but feels like this should be AtomicBoolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think it's necessary
it's accessed by AndroidTransactionProfiler only in the block guarded by its own AtomicBoolean isRunning
📜 Description
Removed lock from AndroidTransactionProfiler
💡 Motivation and Context
Trying to reduce ANRs. There are reports of ANRs happening when getting the lock on transaction start/end
resolves #4792
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps