Skip to content

Conversation

@markushi
Copy link
Member

📜 Description

Tags supplied via Timber

Timber.tag("tag").i("info message")

now get reported as a timber.tag attribute.

💡 Motivation and Context

Better logging

💚 How did you test it?

Added unit tests

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@markushi
Copy link
Member Author

@sentry review

@sentry
Copy link

sentry bot commented Oct 28, 2025

Seer had some issues with your request. Please try again.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 386.22 ms 535.43 ms 149.22 ms
Size 1.58 MiB 2.12 MiB 551.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
27d7cf8 309.43 ms 364.27 ms 54.85 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ce0a49e 532.00 ms 609.96 ms 77.96 ms
b3d8889 420.46 ms 453.71 ms 33.26 ms
27d7cf8 306.76 ms 366.66 ms 59.90 ms
806307f 357.85 ms 424.64 ms 66.79 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
d5a29b6 298.62 ms 391.78 ms 93.16 ms
d364ace 384.53 ms 453.51 ms 68.98 ms

App size

Revision Plain With Sentry Diff
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ce0a49e 1.58 MiB 2.10 MiB 532.94 KiB
b3d8889 1.58 MiB 2.10 MiB 535.07 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
806307f 1.58 MiB 2.10 MiB 533.42 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
d5a29b6 1.58 MiB 2.12 MiB 549.37 KiB
d364ace 1.58 MiB 2.11 MiB 539.75 KiB

Previous results on branch: markushi/feat/log-timber-tags

Startup times

Revision Plain With Sentry Diff
42ae009 359.37 ms 500.61 ms 141.23 ms

App size

Revision Plain With Sentry Diff
42ae009 1.58 MiB 2.12 MiB 551.40 KiB

@markushi
Copy link
Member Author

@sentry review

@markushi markushi changed the title Log Timber tag as attribute feat(logging): Log Timber tag as log attribute Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 13cd8e8

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one Q

@markushi
Copy link
Member Author

@sentry review

@sentry
Copy link

sentry bot commented Oct 30, 2025

Seer had some issues with your request. Please try again.

@markushi markushi merged commit 03dca4e into main Nov 3, 2025
61 checks passed
@markushi markushi deleted the markushi/feat/log-timber-tags branch November 3, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants