Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundleSizeOptimizations.excludeTracing #644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdelStrother
Copy link

This flag was having no effect - the correct name is __SENTRY_TRACING__, not __SENTRY_TRACE__
(see, eg, https://github.com/getsentry/sentry-javascript/blob/8dd8ac556bb429f57ab77475575fbc6520191cdb/packages/core/src/utils/hasTracingEnabled.ts#L5)

This flag was having no effect - the correct name is __SENTRY_TRACING__, not __SENTRY_TRACE__
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dang thanks for catching that. Just checked and it seems like we never called it __SENTRY_TRACE__ so this should be safe to do without any sort of backwards compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants