when tracking threads, use a monotonic clock that ignores system suspension #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension Using the system time causes each suspension to be detected as an event loop delay which is not useful. System suspensions may be common when running in low cost cloud environments where systems are suspended when not actively serving requests.
matthew-nicholson-anrok
force-pushed
the
main
branch
from
3b0e16e to
433b304
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
I've fixed the Windows build from my Windows machine but couldn't push changes to your branch. Here is the patch: |
|
@timfish awesome! I've updated the PR with your patch. |
timfish
approved these changes
Jul 28, 2025
AbhiPrasad
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the system time causes each suspension to be detected as an event loop delay which is not useful. System suspensions may be common when running in low cost cloud environments where systems are suspended when not actively serving requests.
Closes #13
Testing
I am only able to test on macos currently, but the code seems to work as expected there.
eventLoopBlockIntegrationenabled, ensure no event is triggered when resuming