-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(node): Move tracing options to
Http
integration (#6191)
Since both `tracing` and `shouldCreateSpanForRequest` effectively control whether tracing is enabled and have opposing defaults (`tracing: false` and `shouldCreateSpanForRequest: _ => true`), this patch makes `tracing: TracingOptions | boolean` so its not a breaking change and the options don't end up conflicting. ```ts interface TracingOptions { tracePropagationTargets?: TracePropagationTargets; shouldCreateSpanForRequest?: (url: string) => boolean; } interface HttpOptions { breadcrumbs?: boolean; tracing?: TracingOptions | boolean; } ```
- Loading branch information
Showing
5 changed files
with
248 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.