Skip to content

Commit

Permalink
Merge pull request #12987 from getsentry/prepare-release/8.19.0
Browse files Browse the repository at this point in the history
meta(changelog): Update changelog for 8.19.0
  • Loading branch information
andreiborza committed Jul 19, 2024
2 parents ca99121 + 6e562ea commit 39f9e2a
Show file tree
Hide file tree
Showing 67 changed files with 1,429 additions and 1,425 deletions.
52 changes: 12 additions & 40 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 22]
node: [14, 16, 18, 20, 22.4]
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
Expand Down Expand Up @@ -579,7 +579,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 22]
node: [14, 16, 18, 20, 22.4]
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
Expand Down Expand Up @@ -779,33 +779,6 @@ jobs:
name: playwright-traces
path: dev-packages/browser-integration-tests/test-results

job_browser_build_tests:
name: Browser Build Tests
needs: [job_get_metadata, job_build]
runs-on: ubuntu-20.04
timeout-minutes: 5
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
env:
DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Run browser build tests
run: |
cd packages/browser
yarn test:package
- name: Run utils build tests
run: |
cd packages/utils
yarn test:package
job_check_for_faulty_dts:
name: Check for faulty .d.ts files
needs: [job_get_metadata, job_build]
Expand Down Expand Up @@ -843,12 +816,12 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 22]
node: [14, 16, 18, 20, 22.4]
typescript:
- false
include:
# Only check typescript for latest version (to streamline CI)
- node: 22
- node: 22.4
typescript: '3.8'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
Expand Down Expand Up @@ -885,7 +858,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22]
node: [18, 20, 22.4]
remix: [1, 2]
# Remix v2 only supports Node 18+, so run 16 tests separately
include:
Expand Down Expand Up @@ -1317,7 +1290,6 @@ jobs:
[
job_build,
job_compile_bindings_profiling_node,
job_browser_build_tests,
job_browser_unit_tests,
job_bun_unit_tests,
job_deno_unit_tests,
Expand Down Expand Up @@ -1409,7 +1381,7 @@ jobs:
- os: ubuntu-20.04
node: 20
- os: ubuntu-20.04
node: 22
node: 22.4

# x64 musl
- os: ubuntu-20.04
Expand All @@ -1423,7 +1395,7 @@ jobs:
node: 20
- os: ubuntu-20.04
container: node:22-alpine3.18
node: 22
node: 22.4

# arm64 glibc
- os: ubuntu-20.04
Expand All @@ -1437,7 +1409,7 @@ jobs:
node: 20
- os: ubuntu-20.04
arch: arm64
node: 22
node: 22.4

# arm64 musl
- os: ubuntu-20.04
Expand All @@ -1455,7 +1427,7 @@ jobs:
- os: ubuntu-20.04
arch: arm64
container: node:22-alpine3.18
node: 22
node: 22.4

# macos x64
- os: macos-13
Expand All @@ -1468,7 +1440,7 @@ jobs:
node: 20
arch: x64
- os: macos-13
node: 22
node: 22.4
arch: x64

# macos arm64
Expand All @@ -1486,7 +1458,7 @@ jobs:
target_platform: darwin
- os: macos-13
arch: arm64
node: 22
node: 22.4
target_platform: darwin

# windows x64
Expand All @@ -1500,7 +1472,7 @@ jobs:
node: 20
arch: x64
- os: windows-2022
node: 22
node: 22.4
arch: x64

steps:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
- fix(angular): Remove `afterSendEvent` listener once root injector is destroyed (#12786)
- fix(browser): Fix bug causing unintentional dropping of transactions (#12933)
- fix(feedback): Add a missing call of Actor.appendToDom method when DOMContentLoaded event is triggered (#12973)
- feat(vercel-edge): Add dedupe as default integration (#12957)
- fix(node): Pass inferred name & attributes to `tracesSampler` (#12945)
- feat(express): Allow to pass options to `setupExpressErrorHandler` (#12952)

Work in this release was contributed by @jaspreet57 and @arturovt. Thank you for your contribution!

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ package. Please refer to the README and instructions of those SDKs for more deta
- [`@sentry/vue`](https://github.com/getsentry/sentry-javascript/tree/master/packages/vue): Browser SDK for Vue
- [`@sentry/solid`](https://github.com/getsentry/sentry-javascript/tree/master/packages/solid): Browser SDK for Solid
- [`@sentry/gatsby`](https://github.com/getsentry/sentry-javascript/tree/master/packages/gatsby): SDK for Gatsby
- [`@sentry/nestjs`](https://github.com/getsentry/sentry-javascript/tree/master/packages/nestjs): SDK for NestJS
- [`@sentry/nextjs`](https://github.com/getsentry/sentry-javascript/tree/master/packages/nextjs): SDK for Next.js
- [`@sentry/remix`](https://github.com/getsentry/sentry-javascript/tree/master/packages/remix): SDK for Remix
- [`@sentry/aws-serverless`](https://github.com/getsentry/sentry-javascript/tree/master/packages/aws-serverless): SDK
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,3 @@
/* eslint-disable no-console */
const Sentry = require('../../build/npm/cjs/index.js');

// Init
Sentry.init({
dsn: 'https://[email protected]/42',
beforeSend(_event) {
console.log('Got an event');
return null;
},
beforeBreadcrumb(crumb) {
console.log(`Got a breadcrumb: ${crumb.category}`);
return crumb;
},
});

// Configure
const scope = Sentry.getCurrentScope();
scope.setExtra('foo', 'bar');
scope.setFingerprint('foo');
Expand Down Expand Up @@ -75,6 +58,5 @@ Sentry.withScope(scope => {

var xhr = new XMLHttpRequest();
xhr.onload = () => console.log('loaded'); // This throws error
// xhr.addEventListener("load", () => console.log('loaded')); This does not throw error
xhr.open('GET', 'https://httpbin.org/get');
xhr.send();
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import * as fs from 'node:fs';
import * as path from 'node:path';

import { expect } from '@playwright/test';

import { sentryTest } from '../../../../utils/fixtures';

// Regression test against https://github.com/getsentry/sentry-javascript/pull/1896
sentryTest('should not contain tslib_1__default', async ({ getLocalTestPath }) => {
await getLocalTestPath({ testDir: __dirname });

const initBundle = fs.readFileSync(path.join(__dirname, 'dist', 'init.bundle.js'), 'utf-8');
expect(initBundle.length).toBeGreaterThan(0);
expect(initBundle).not.toContain('tslib_1__default');

const subjectBundle = fs.readFileSync(path.join(__dirname, 'dist', 'subject.bundle.js'), 'utf-8');
expect(subjectBundle.length).toBeGreaterThan(0);
expect(subjectBundle).not.toContain('tslib_1__default');
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
const { loggingTransport } = require('@sentry-internal/node-integration-tests');
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
transport: loggingTransport,
tracesSampler: samplingContext => {
// The name we get here is inferred at span creation time
// At this point, we sadly do not have a http.route attribute yet,
// so we infer the name from the unparametrized route instead
return (
samplingContext.name === 'GET /test/123' &&
samplingContext.attributes['sentry.op'] === 'http.server' &&
samplingContext.attributes['http.method'] === 'GET'
);
},
debug: true,
});

// express must be required after Sentry is initialized
const express = require('express');
const cors = require('cors');
const { startExpressServerAndSendPortToRunner } = require('@sentry-internal/node-integration-tests');

const app = express();

app.use(cors());

app.get('/test/:id', (_req, res) => {
res.send('Success');
});

app.get('/test2', (_req, res) => {
res.send('Success');
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { cleanupChildProcesses, createRunner } from '../../../../utils/runner';

describe('express tracesSampler', () => {
afterAll(() => {
cleanupChildProcesses();
});

describe('CJS', () => {
test('correctly samples & passes data to tracesSampler', done => {
const runner = createRunner(__dirname, 'server.js')
.expect({
transaction: {
transaction: 'GET /test/:id',
},
})
.start(done);

// This is not sampled
runner.makeRequest('get', '/test2?q=1');
// This is sampled
runner.makeRequest('get', '/test/123?q=1');
});
});
});
9 changes: 9 additions & 0 deletions docs/changelog/v7.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
Support for Sentry SDK v7 will be dropped soon. We recommend migrating to the latest version of the SDK. You can migrate
from `v7` to `v8 of the SDK by following the [migration guide](../../MIGRATION.md).

## 7.118.0

- fix(v7/bundle): Ensure CDN bundles do not overwrite `window.Sentry` (#12579)

## 7.117.0

- feat(browser/v7): Publish browserprofling CDN bundle (#12224)
- fix(v7/publish): Add `v7` tag to `@sentry/replay` (#12304)

## 7.116.0

- build(craft): Publish lambda layer under its own name for v7 (#12098) (#12099)
Expand Down
6 changes: 1 addition & 5 deletions packages/astro/vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
import type { UserConfig } from 'vitest';

import baseConfig from '../../vite/vite.config';

export default {
...baseConfig,
test: {
// test exists, no idea why TS doesn't recognize it
// eslint-disable-next-line @typescript-eslint/no-explicit-any
...(baseConfig as UserConfig & { test: any }).test,
...baseConfig.test,
environment: 'jsdom',
},
};
4 changes: 1 addition & 3 deletions packages/browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@
},
"devDependencies": {
"@sentry-internal/integration-shims": "8.18.0",
"fake-indexeddb": "^4.0.1",
"webpack": "^4.47.0"
"fake-indexeddb": "^4.0.1"
},
"scripts": {
"build": "run-p build:transpile build:bundle build:types",
Expand All @@ -73,7 +72,6 @@
"size:check": "cat build/bundles/bundle.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES2017: \",$1,\"kB\";}'",
"test": "yarn test:unit",
"test:unit": "jest",
"test:package": "node test/package/npm-build.js && rm test/package/tmp.js",
"test:unit:watch": "jest --watch",
"yalc:publish": "yalc publish --push --sig"
},
Expand Down
69 changes: 0 additions & 69 deletions packages/browser/test/package/npm-build.js

This file was deleted.

Loading

0 comments on commit 39f9e2a

Please sign in to comment.