fix(profiling) segfault on close

getsentry · Sep 10, 2024 · 561faff · 561faff
1 parent 0812b24
commit 561faff
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/profiling-node/bindings/cpu_profiler.cc b/packages/profiling-node/bindings/cpu_profiler.cc
@@ -113,7 +113,12 @@ class MeasurementsTicker {
 
   void Cleanup() {
     uv_timer_stop(&timer);
-    uv_close(reinterpret_cast<uv_handle_t *>(&timer), nullptr);
+
+    auto handle = reinterpret_cast<uv_handle_t *>(&timer);
+
+    if(!uv_is_closing(handle)) {
+      uv_close(handle, free_timer_callback);
+    }
   }
 };