Skip to content

Commit

Permalink
Update portfinder to 1.0.32
Browse files Browse the repository at this point in the history
  • Loading branch information
onurtemizkan committed Jul 20, 2023
1 parent 2b0b59c commit 72dfd7c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/remix/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@remix-run/node": "^1.4.3",
"@remix-run/react": "^1.4.3",
"@types/express": "^4.17.14",
"portfinder": "^1.0.28"
"portfinder": "^1.0.32"
},
"peerDependencies": {
"@remix-run/node": "1.x",
Expand Down Expand Up @@ -69,7 +69,7 @@
"lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\"",
"test": "yarn test:unit",
"test:integration": "run-s test:integration:v1 test:integration:v2",
"test:integration:v1": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server",
"test:integration:v1": "run-s test:integration:prepare test:integration:client test:integration:server",
"test:integration:v2": "export REMIX_VERSION=2 && run-s test:integration:v1",
"test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client:ci test:integration:server",
"test:integration:prepare": "(cd test/integration && yarn)",
Expand Down
7 changes: 6 additions & 1 deletion packages/remix/test/integration/test/server/utils/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ export class RemixTestEnv extends TestEnv {

app.all('*', requestHandlerFactory({ build: require('../../../build') }));

getPort((_, port) => {
getPort((err, port) => {
if (err) {
console.warn('portfinder failed to find an open port, using 8000', err);
port = 8000;
}

serverPort = port;
const server = app.listen(port, () => {
resolve(server);
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -21266,7 +21266,7 @@ [email protected], pnp-webpack-plugin@^1.6.4:
dependencies:
ts-pnp "^1.1.6"

portfinder@^1.0.26, portfinder@^1.0.28, portfinder@^1.0.29:
portfinder@^1.0.26, portfinder@^1.0.29, portfinder@^1.0.32:
version "1.0.32"
resolved "https://registry.yarnpkg.com/portfinder/-/portfinder-1.0.32.tgz#2fe1b9e58389712429dc2bea5beb2146146c7f81"
integrity sha512-on2ZJVVDXRADWE6jnQaX0ioEylzgBpQk8r55NE4wjXW1ZxO+BgDlY6DXwj20i0V8eB4SenDQ00WEaxfiIQPcxg==
Expand Down

0 comments on commit 72dfd7c

Please sign in to comment.