fix(utils): Avoid pre_context and context_line overlap if frame l…

…ineno is out of bounds (#8722)
getsentry · Aug 2, 2023 · 85effab · 85effab
1 parent 4b383d0
commit 85effab
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/utils/src/misc.ts b/packages/utils/src/misc.ts
@@ -153,7 +153,7 @@ export function addContextToFrame(lines: string[], frame: StackFrame, linesOfCon
   }
 
   const maxLines = lines.length;
-  const sourceLine = Math.max(Math.min(maxLines, frame.lineno - 1), 0);
+  const sourceLine = Math.max(Math.min(maxLines - 1, frame.lineno - 1), 0);
 
   frame.pre_context = lines
     .slice(Math.max(0, sourceLine - linesOfContext), sourceLine)

diff --git a/packages/utils/test/misc.test.ts b/packages/utils/test/misc.test.ts
@@ -181,10 +181,20 @@ describe('addContextToFrame', () => {
       lineno: 999,
     };
     addContextToFrame(lines, frame);
-    expect(frame.pre_context).toEqual(['10: j', '11: k', '12: l', '13: m', '14: n']);
+    expect(frame.pre_context).toEqual(['9: i', '10: j', '11: k', '12: l', '13: m']);
     expect(frame.context_line).toEqual('14: n');
     expect(frame.post_context).toEqual([]);
   });
+
+  test('truncate line if too long', () => {
+    const frame: StackFrame = {
+      lineno: 1,
+    };
+    addContextToFrame(['1234567890'.repeat(100)], frame);
+    expect(frame.pre_context).toEqual([]);
+    expect(frame.context_line).toEqual(`${'1234567890'.repeat(14)} {snip}`);
+    expect(frame.post_context).toEqual([]);
+  });
 });
 
 describe('addExceptionMechanism', () => {